751678 - Low-res screenshot happens when Fennec is in the background

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We should probably turn-off low-res screenshot code when in the background.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 620947 [details] [diff] [review]
patch

>+        GeckoAppShell.sIsPaused = false;

>+        GeckoAppShell.sIsPaused = true;

>+    public static boolean sIsPaused = false;


We already have a flag like this in all GeckoActivity classes, like GeckoApp. You should be able to use:

GeckoApp.mAppContext.isApplicationInBackground()

r+ if we don't need sIsPaused

Comment 3

[:ehsan akhgari]

https://hg.mozilla.org/mozilla-central/rev/def98285ad87

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Does this bug need to be fixed on aurora?

Comment 5

[Aaron Train [:aaronmt]]

I see this on the current (14) beta build.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

this bug depends on bug 751690, which has been uplifted to aurora

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 620947 [details] [diff] [review]
patch

[Triage Comment]

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/61edcd0409bb

Comment 9

[Aaron Train [:aaronmt]]

WFM all around