Low-res screenshot happens when Fennec is in the background

VERIFIED FIXED in Firefox 14

Status

()

Product:
Firefox for Android
Component:
General
VERIFIED FIXED
Reported:
6 years ago
Modified:
2 years ago

People

(Reporter: mfinkle, Assigned: blassey)

Tracking

Version:
Trunk
Target:
Firefox 15
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox14 verified, firefox15 verified, firefox16 verified, firefox17 verified, blocking-fennec1.0 +)

Details

Attachments

(1 attachment)

patch
1.75 KB, patch
mfinkle
: review+
mfinkle
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(Reporter)

Description

•
6 years ago 
We should probably turn-off low-res screenshot code when in the background.

Updated

•
6 years ago
OS: Linux → Android
Hardware: x86 → ARM
Version: unspecified → Trunk
 (Assignee)

Comment 1

•
6 years ago 
Created attachment 620947 [details] [diff] [review]
patch
Attachment #620947 - Flags: review?(mark.finkle)
 (Reporter)

Comment 2

•
6 years ago 
Comment on attachment 620947 [details] [diff] [review]
patch

>+        GeckoAppShell.sIsPaused = false;

>+        GeckoAppShell.sIsPaused = true;

>+    public static boolean sIsPaused = false;


We already have a flag like this in all GeckoActivity classes, like GeckoApp. You should be able to use:

GeckoApp.mAppContext.isApplicationInBackground()

r+ if we don't need sIsPaused
Attachment #620947 - Flags: review?(mark.finkle) → review+

Comment 3

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/def98285ad87
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
 (Reporter)

Comment 4

•
6 years ago 
Does this bug need to be fixed on aurora?

Comment 5

•
6 years ago 
I see this on the current (14) beta build.
status-firefox14: --- → affected
 (Reporter)

Comment 6

•
6 years ago 
this bug depends on bug 751690, which has been uplifted to aurora
 (Reporter)

Comment 7

•
6 years ago 
Comment on attachment 620947 [details] [diff] [review]
patch

[Triage Comment]
Attachment #620947 - Flags: approval-mozilla-aurora+
 (Reporter)

Comment 8

•
6 years ago 
https://hg.mozilla.org/releases/mozilla-aurora/rev/61edcd0409bb
status-firefox14: affected → fixed
status-firefox15: --- → fixed

Comment 9

•
6 years ago 
WFM all around
Status: RESOLVED → VERIFIED
status-firefox14: fixed → verified
status-firefox15: fixed → verified
status-firefox16: --- → verified
status-firefox17: --- → verified
You need to log in before you can comment on or make changes to this bug.