Last Comment Bug 751766 - Remove unused function MOZ_Crash
: Remove unused function MOZ_Crash
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MFBT (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Chris Peterson [:cpeterson]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-03 16:43 PDT by Chris Peterson [:cpeterson]
Modified: 2012-05-05 03:38 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
bug-751766-remove-MOZ_Crash.patch (2.55 KB, patch)
2012-05-03 16:44 PDT, Chris Peterson [:cpeterson]
mh+mozilla: review+
Details | Diff | Splinter Review

Description Chris Peterson [:cpeterson] 2012-05-03 16:43:24 PDT
cset 20218c1c79e0 replaced MOZ_Crash's function prototype with the MOZ_CRASH macro, but did not remove MOZ_Crash's function definition. So the MOZ_Crash function exists in Assertions.cpp, but no one can call it.

https://hg.mozilla.org/mozilla-central/rev/20218c1c79e0

I submitted a try build to test compilation on all platforms:

https://tbpl.mozilla.org/?tree=Try&rev=85076195b235
Comment 1 Chris Peterson [:cpeterson] 2012-05-03 16:44:41 PDT
Created attachment 620893 [details] [diff] [review]
bug-751766-remove-MOZ_Crash.patch

Remove unused function MOZ_Crash.
Comment 2 Chris Peterson [:cpeterson] 2012-05-04 13:28:44 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f21124ebc63
Comment 3 Ed Morley [:emorley] 2012-05-05 03:38:41 PDT
https://hg.mozilla.org/mozilla-central/rev/3f21124ebc63

Note You need to log in before you can comment on or make changes to this bug.