[AccessFu] disable() does not shut down event listeners

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla15
ARM
Android
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
event callbacks keep getting called. this included key presses, a11y events, and other DOM events we add listeners to when first calling enable().
(Assignee)

Updated

5 years ago
Summary: [AccessFu] disable() does not work well → [AccessFu] disable() does not shut down event listeners
(Assignee)

Comment 1

5 years ago
Created attachment 620933 [details] [diff] [review]
shut down AccessFu properly on disable().

I was just being really sloppy in the detach() and enable methods..
Attachment #620933 - Flags: review?(dbolter)
Comment on attachment 620933 [details] [diff] [review]
shut down AccessFu properly on disable().

OK r=me. I had to refresh myself (via nsIDOMEventTarget.idl comments). Basically you have to add the usecapture arg since you add the event listeners with capture true right? Also the (haha!) s/addObserver/removeObserver should make things nicer :)
Attachment #620933 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
yes. you need the usecapture flag. thanks!
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/b58c6e5156d7
http://hg.mozilla.org/mozilla-central/rev/b58c6e5156d7

Should this have a test?
Assignee: nobody → eitan
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.