Closed Bug 751841 Opened 12 years ago Closed 12 years ago

[RTL] Line numbering broken if line starts with RTL character

Categories

(Toolkit :: View Source, defect)

13 Branch
x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: tomer, Assigned: smontagu)

References

Details

(Keywords: rtl)

Attachments

(3 files)

Firefox doesn't display line numbering right when the content has lines that start with RTL characters such as Arabic and Hebrew. Instead, it appears behind the source text making the source less readable and the line numbering to appear to fewer lines.

The issue does reproduce only to lines that starts with RTL character, so it won't reproduce on pages that the author have indented the source lines in the <body> block…
Component: Developer Tools → View Source
Product: Firefox → Toolkit
QA Contact: developer.tools → view.source
Attached patch PatchSplinter Review
This is caused by the line numbers participating in bidi reordering. Changing from unicode-bidi: embed to unicode-bidi: -moz-isolate would be enough to fix it, except for bug 717811, so I have added a workaround for that as well.
Attachment #627862 - Flags: review?(ehsan)
Depends on: 717811
Comment on attachment 627862 [details] [diff] [review]
Patch

Hmm, does "\200e" work, or did you mean "\u200e"?  r=me with whichever works correctly.
Attachment #627862 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e98f0fc3d02e
Assignee: nobody → smontagu
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/e98f0fc3d02e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 760954
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: