Closed Bug 751866 Opened 12 years ago Closed 12 years ago

Cannot generate a report if all entries in a manifest file are disabled

Categories

(Testing Graveyard :: Mozmill, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davehunt, Assigned: k0scist)

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(2 files)

There is an issue when generating a report when all entries in a manifest file are disabled. The following is thrown:

$ mozmill -m tests/l10n/manifest.ini -b /Applications/FirefoxNightly.app/Contents/MacOS/firefox --report=stdout
WARNING | testAccessKeys | (SKIP) skipme
WARNING | testCropped | (SKIP) "Bug 614579 - Crop test sometimes shows single line for cropped elements"
ERROR | Traceback (most recent call last):
ERROR |   File "/Users/dhunt/.virtualenvs/mozmill-master/bin/mozmill", line 8, in <module>
ERROR | 
ERROR | load_entry_point('mozmill==2.0rc1', 'console_scripts', 'mozmill')()
ERROR |   File "/Users/dhunt/workspace/mozmill/mozmill/mozmill/__init__.py", line 678, in cli
ERROR | 
ERROR | CLI(args).run()
ERROR |   File "/Users/dhunt/workspace/mozmill/mozmill/mozmill/__init__.py", line 665, in run
ERROR | 
ERROR | results.finish(self.event_handlers, fatal=exception is not None)
ERROR |   File "/Users/dhunt/workspace/mozmill/mozmill/mozmill/__init__.py", line 106, in finish
ERROR | 
ERROR | handler.stop(self, fatal)
ERROR |   File "/Users/dhunt/workspace/mozmill/mozmill/mozmill/report.py", line 75, in stop
ERROR | 
ERROR | results = self.get_report(results)
ERROR |   File "/Users/dhunt/workspace/mozmill/mozmill/mozmill/report.py", line 93, in get_report
ERROR | 
ERROR | report.update(results.appinfo)
ERROR | TypeError
ERROR | :
ERROR | 'NoneType' object is not iterable
ERROR |
Whiteboard: [mozmill-2.0?]
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
Assignee: nobody → jhammel
This fails on appinfo since, currently, we don't gather any application information without starting the runner:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L268

Do we want to start the runner to gather the application information in this case?  Or just report a blank dictionary?
This just sends empty appinfo.  Alternatively, we can fire the browser at least once in the case where we have no tests if we *really* want the app info
Attachment #626740 - Flags: feedback?(dave.hunt)
This will start+stop the browser to gather the appinfo
Attachment #626743 - Flags: review?(dave.hunt)
Comment on attachment 626743 [details] [diff] [review]
get appinfo on .stop() if it is not filled out

Looks great. Thanks Jeff!
Attachment #626743 - Flags: review?(dave.hunt) → review+
Comment on attachment 626740 [details] [diff] [review]
very simple fix that just reports empty appinfo

Going with patch number 2!
Attachment #626740 - Flags: feedback?(dave.hunt) → feedback-
pushed:https://github.com/mozautomation/mozmill/commit/5a2d2523a0d10b1d58bdbdaecfb90cb2f94f110e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: