Going back one page in stack doesn't work (since yesterday)

RESOLVED FIXED in M3

Status

Pancake
Front-end
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dria, Assigned: gordonb)

Tracking

unspecified
x86
Mac OS X

Details

The stack ordering updates much more intuitively now, imo (most recent page floats to top), but there seems to be a problem with going back one page in the stack now.

STR:

1) Go to the front page of reddit
2) Click any link -- you'll be taken to a new page
3) Click on the page in the stack for the previous page
4) That item in the stack floats to the top, but the page doesn't load

I've tested this on a couple of sites and it seems to be consistent.  It's also not just the first page you visit in the stack -- going back one page from any other page doesn't seem to work.
Whatever this was, it appears to have been fixed or I was just doing it wrong.  Resolving.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
I'm running into this again this morning on all stacks on Dev. Trying to go back to the previous item in the stack doesn't work -- I have to go to another page *then* to the page I wanted to go back to.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Updated

6 years ago
Assignee: nobody → gbrander
(Assignee)

Updated

6 years ago
Status: REOPENED → ASSIGNED
(Assignee)

Comment 3

6 years ago
This only seems to happen directly after creating a new place. If you quit/open the app and open a stack, you can navigate freely between places without issue.
(Assignee)

Comment 4

6 years ago
Not getting very far with this due to issues with troubleshooting env. Going to set aside until I can get with st3fan and get the simulator running properly with logging on my local.
(Assignee)

Comment 5

6 years ago
While troubleshooting this, I found that after you add a new place to the collection:

1. Clicking the previous place will scroll to the viewer, but will not load the URL
2. You can click the previous place as many times as you want, it won't load
3. The click event makes it all the way to TOP, where a load:url message is sent to native.
4. The only place state is kept for loading URLs is in top.app.js, loadUrl, where the last-loaded URL is stored, and further requests for that same URL are ignored (no event is sent to native). I commented out this if clause (meaning an event is sent to native no matter what). No change.

Because of #4, I think this might be an issue on the iOS side. St3fan, could you quickly check to see if it is and let me know? Thanks very much.
Assignee: gbrander → sarentz
Status: ASSIGNED → NEW
(Assignee)

Updated

6 years ago
Assignee: sarentz → nobody
Component: Front-end → Native iOS Wrapper
QA Contact: frontend → ioswrapper
(Assignee)

Updated

6 years ago
Assignee: nobody → sarentz
Assigning back to frontend. I've tested this and the iOS app simply does not receive the url:open command.

So I think this is a case where the frontend thinks it is still on the previous page and does not send a request to open the page.

This is from the log:


2012-05-18 10:35:48.930 PancakeDevelopment[19489:f803] LOG - TOP - "top (ios): handling  xmessage: place:change"
2012-05-18 10:35:48.931 PancakeDevelopment[19489:f803] LOG - TOP - "top: xmessage, calling handler: onPlaceChange"
2012-05-18 10:35:48.931 PancakeDevelopment[19489:f803] LOG - TOP - "loadPlace: ae12a7838234437d93c06991788f192b / ac56a9d1e5e848ca844a4d7b80358e9c"
2012-05-18 10:35:48.932 PancakeDevelopment[19489:f803] LOG - TOP - "Not warping with place:change: ", {"stack_id":"ae12a7838234437d93c06991788f192b","session_id":"285e2cbba33c4d6fab1eb58c7d123b79","place_url":"http://www.reddit.com/","place_id":"ac56a9d1e5e848ca844a4d7b80358e9c"}
2012-05-18 10:35:48.932 PancakeDevelopment[19489:f803] LOG - TOP - "update state from msg: ", "{\"stack_id\":\"ae12a7838234437d93c06991788f192b\",\"session_id\":\"285e2cbba33c4d6fab1eb58c7d123b79\",\"place_url\":\"http://www.reddit.com/\",\"place_id\":\"ac56a9d1e5e848ca844a4d7b80358e9c\"}"
2012-05-18 10:35:48.933 PancakeDevelopment[19489:f803] LOG - TOP - "top: place:change result: \"null\""
Assignee: sarentz → gbrander
Assignee: gbrander → nobody
Component: Native iOS Wrapper → Front-end
QA Contact: ioswrapper → frontend
(Assignee)

Comment 7

6 years ago
Thanks for looking into this. I'll continue troubleshooting on the front-end.
(Assignee)

Updated

6 years ago
Assignee: nobody → gbrander
Fixed with: https://bitbucket.org/mozillapancake/pancake/changeset/21f5829aa151
..needed to update the viewer_url attribute with the new url we get in onNavigate
Status: NEW → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.