Closed
Bug 751916
Opened 13 years ago
Closed 13 years ago
Tiling-related glitching on tbpl
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(blocking-fennec1.0 -)
RESOLVED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
blocking-fennec1.0 | --- | - |
People
(Reporter: kats, Assigned: BenWa)
References
Details
Attachments
(2 files)
457.15 KB,
image/jpeg
|
Details | |
1.04 KB,
patch
|
joe
:
review+
akeybl
:
approval-mozilla-aurora-
akeybl
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
STR:
1. Load tbpl.mozilla.org
2. Try panning/pinching
Expected results:
page draws normally
Actual results:
occasionally the page background goes black, sometimes the black area is obviously tiled rects. it's a little hard to explain but not that hard to reproduce. See attached screenshot.
It's a pretty severe issue and should be blocking.
Tested on both the Galaxy Nexus and Galaxy Tab with a build from 9ebf3dc839c5 (recent m-c)
Comment 1•13 years ago
|
||
Can reproduce, no ideas immediately spring to mind of what this could be.
Assignee | ||
Comment 2•13 years ago
|
||
Probably my bug. Most likely a problem with either opaque surface and/or clearing the surface.
Assignee: nobody → bgirard
Updated•13 years ago
|
blocking-fennec1.0: ? → -
Comment 3•13 years ago
|
||
We'll approve things for fixing the test though
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #656983 -
Flags: review?(joe)
Updated•13 years ago
|
Attachment #656983 -
Flags: review?(joe) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 656983 [details] [diff] [review]
Don't reuse an old tile if the format changed
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 739679
User impact if declined: Users will see black tiles on some more complex pages with transparent layers (ex: TBPL, google news reader)
Testing completed (on m-c, etc.): on inbound, soon on m-c
Risk to taking this patch (and alternatives if risky): Fennec only, low one line change.
String or UUID changes made by this patch: one
Attachment #656983 -
Flags: approval-mozilla-beta?
Attachment #656983 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Comment 10•13 years ago
|
||
Comment on attachment 656983 [details] [diff] [review]
Don't reuse an old tile if the format changed
[Triage Comment]
Low risk mobile-only fix in support of web compatibility. Approving for Aurora 17 and Beta 16.
Attachment #656983 -
Flags: approval-mozilla-beta?
Attachment #656983 -
Flags: approval-mozilla-beta+
Attachment #656983 -
Flags: approval-mozilla-aurora?
Attachment #656983 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 11•13 years ago
|
||
This patch isn't going to get uplifted because of the regressions.
Comment 12•13 years ago
|
||
Yeah, I believe this patch unintentionally caused issues here:
https://bugzilla.mozilla.org/show_bug.cgi?id=787732
Am I correct? Just trying to follow what's going on here, it's quite fast-paced. That's what you mean by regressions, right?
Assignee | ||
Comment 13•13 years ago
|
||
Yes, there's a fix underway.
Updated•13 years ago
|
Attachment #656983 -
Flags: approval-mozilla-beta-
Attachment #656983 -
Flags: approval-mozilla-beta+
Attachment #656983 -
Flags: approval-mozilla-aurora-
Attachment #656983 -
Flags: approval-mozilla-aurora+
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•