751916 - Tiling-related glitching on tbpl

Status: RESOLVED FIXED

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

STR:

1. Load tbpl.mozilla.org
2. Try panning/pinching

Expected results:
page draws normally

Actual results:
occasionally the page background goes black, sometimes the black area is obviously tiled rects. it's a little hard to explain but not that hard to reproduce. See attached screenshot.

It's a pretty severe issue and should be blocking.

Tested on both the Galaxy Nexus and Galaxy Tab with a build from 9ebf3dc839c5 (recent m-c)

Comment 1

[Chris Lord [:cwiiis]]

Can reproduce, no ideas immediately spring to mind of what this could be.

Comment 2

[Benoit Girard (:BenWa)]

Probably my bug. Most likely a problem with either opaque surface and/or clearing the surface.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

We'll approve things for fixing the test though

Comment 6

[Benoit Girard (:BenWa)]

Attachment: Don't reuse an old tile if the format changed

Comment 7

[Benoit Girard (:BenWa)]

Comment on attachment 656983 [details] [diff] [review]
Don't reuse an old tile if the format changed

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 739679
User impact if declined: Users will see black tiles on some more complex pages with transparent layers (ex: TBPL, google news reader)
Testing completed (on m-c, etc.): on inbound, soon on m-c
Risk to taking this patch (and alternatives if risky): Fennec only, low one line change.
String or UUID changes made by this patch: one

Comment 8

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d04edff1ae41

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d04edff1ae41

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 656983 [details] [diff] [review]
Don't reuse an old tile if the format changed

[Triage Comment]
Low risk mobile-only fix in support of web compatibility. Approving for Aurora 17 and Beta 16.

Comment 11

[Benoit Girard (:BenWa)]

This patch isn't going to get uplifted because of the regressions.

Comment 12

[Michael Loney]

Yeah, I believe this patch unintentionally caused issues here:
https://bugzilla.mozilla.org/show_bug.cgi?id=787732
Am I correct? Just trying to follow what's going on here, it's quite fast-paced. That's what you mean by regressions, right?

Comment 13

[Benoit Girard (:BenWa)]

Yes, there's a fix underway.