751925 - Warning "octal literals and octal escape sequences are deprecated" in datetimepickers.xml

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Stefan Sitter [:ssitter]]

Shown in console after open the event dialog:

Warning: octal literals and octal escape sequences are deprecated
Source file: chrome://calendar/content/datetimepickers/datetimepickers.xml
Line: 1572, Column: 23
Source code:
                  case 02:    this.twoDigitYear = true; // fall thru 

Warning: octal literals and octal escape sequences are deprecated
Source file: chrome://calendar/content/datetimepickers/datetimepickers.xml
Line: 1594, Column: 25
Source code:
                    case 02:    this.twoDigitYear = true; // fall thru

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Fixes mentioned warnings, and a few other obvious ones.

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 625849 [details] [diff] [review]
Fix - v1

>+++ b/calendar/base/content/widgets/calendar-widgets.xml
>@@ -214,6 +214,8 @@
>                 let modeAttributeValues = this.getAttribute(aModeAttribute).split(",");
>                 let modes = this.getAttribute("mode").split(",");
>                 return modeAttributeValues[modes.indexOf(lMode)];
>+            } else {
>+                return "";

Maybe this should return e.g. |null| instead of an string object?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Stefan Sitter from comment #2)
> Comment on attachment 625849 [details] [diff] [review]
> Fix - v1
> 
> >+++ b/calendar/base/content/widgets/calendar-widgets.xml
> >@@ -214,6 +214,8 @@
> >                 let modeAttributeValues = this.getAttribute(aModeAttribute).split(",");
> >                 let modes = this.getAttribute("mode").split(",");
> >                 return modeAttributeValues[modes.indexOf(lMode)];
> >+            } else {
> >+                return "";
> 
> Maybe this should return e.g. |null| instead of an string object?

I have aligned this with the return value of the currentMode getter. The only caller sets the panel's width, which will probably fail both if set to null or "" so I don't think it matters.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset ae4c74d92fd1

Comment 5

[Stefan Sitter [:ssitter]]

Reopening because it seems to have regressed bug 760806.

Comment 6

[Stefan Sitter [:ssitter]]

Fix for the regression was checked in using bug 760806.