Closed
Bug 751999
Opened 12 years ago
Closed 12 years ago
Split SetDocShell apart so it's easier to see what's going on.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
12.31 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
nsGlobalWindow::SetDocShell does two very different things, depending on whether it gets called with a null or a non-null docshell. Having two separate functions makes it easier to read, imo.
Attachment #621136 -
Flags: review?(jst)
Comment 1•12 years ago
|
||
Comment on attachment 621136 [details] [diff] [review] Patch Review of attachment 621136 [details] [diff] [review]: ----------------------------------------------------------------- I like! ::: dom/base/nsGlobalWindow.cpp @@ +2240,5 @@ > + if (parentWindow.get() != static_cast<nsIDOMWindow*>(this)) { > + nsCOMPtr<nsPIDOMWindow> piWindow(do_QueryInterface(parentWindow)); > + mChromeEventHandler = piWindow->GetChromeEventHandler(); > + } > + else { } else { @@ +2253,5 @@ > + > +void > +nsGlobalWindow::DetachFromDocShell() > +{ > + NS_ASSERTION(IsOuterWindow(), "Uh, SetDocShell() called on inner window!"); Fix message
Updated•12 years ago
|
Attachment #621136 -
Flags: review?(jst) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/45a8b9f1a411
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•