752067 - build broken in ipc after prctl changes

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Marco Perez [:mpk]]

Landing the patch for bug 750498 broke builds in FreeBSD (and probably OpenBSD too).
I'll attach a patch shortly.

Comment 1

[Marco Perez [:mpk]]

Attachment: patch to unbreak the build on FreeBSD (maybe OpenBSD too)

This patch unbreaks the bustage due to "prctl.h not found" on FreeBSD.

Landry, before asking for review  I'd like to know if the builds are
indeed broken on OpenBSD too and if this patch remedies the problem.

Comment 2

[Landry Breuil (:gaston)]

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/376/steps/build/logs/stdio

So yes, broken for me too. Testing you fix.

Comment 3

[Landry Breuil (:gaston)]

Works here. As a sidenote, maybe we can add the NetBSD/DragonflyBSD folks to the ifdefs, even if they don't seem to be here to fight for their cause ?

Comment 4

[Marco Perez [:mpk]]

Attachment: patch v2 (supporting Free/Net/Open/DragonFly - BSD)

Sure, makes sense. DragonFly's implementation looks a lot like ours,
but NetBSD's is a bit different, so I hope I got it right.

There has been little NetBSD-related activity in Bugzilla for the last
two years. Landry, do you know any of NetBSD's Firefox maintainers?
If not I'll try to cc: tnn.

Comment 5

[Landry Breuil (:gaston)]

tnn@ did a lot in the past, but it seems those days ryoon@ and martin@ take care of that.

Comment 6

[Martin Husemann]

Re: activity: nobody ever commits our patches, so we just keep accumulating more and more ;-) There is no pthread_np.h on NetBSD, the pthread_setname_np() looks correct.

Comment 7

[Landry Breuil (:gaston)]

I think as of now the patch will include <sys/prctl.h> on NetBSD and that's probably not intended.

Comment 8

[Marco Perez [:mpk]]

Comment on attachment 621276 [details] [diff] [review]
patch v2 (supporting Free/Net/Open/DragonFly - BSD)

You're right. :-)
Now let's concentrate on that "BSD super bug" and its patch over at bug 753046.

Comment 9

[Landry Breuil (:gaston)]

We can still land that first.. oh well :)

Comment 10

[Marco Perez [:mpk]]

We still can, but I'll need to fix it anyway. :-)

Comment 11

[Landry Breuil (:gaston)]

Since #753046 is not moving, can we land a quickfix now for that bug ? that'd be one less patch in my mqs..

Comment 12

[Marco Perez [:mpk]]

Attachment: patch v3 (supporting Free/Net/Open/DragonFly - BSD)

Yes. The "BSD super bug" will require quite a bit of work.

This patch should work for the 4 BSDs without breaking other platforms.

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 625254 [details] [diff] [review]
patch v3 (supporting Free/Net/Open/DragonFly - BSD)

rs=me

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbf995d86990

Thanks for the patch!

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dbf995d86990