752074 - Add add_new_release and change_featured_versions functions

Status: RESOLVED FIXED

(Socorro :: Database, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

To manipulate products / versions in Postgres we will need those two functions to be added.

Comment 1

[[:jberkus] Josh Berkus]

spec:

add_new_release ( 
  product_name
  version
  release_channel
  build_id
  platform
  beta_number (optional)
  repository
)


change_featured_versions (
  product_name
  featured_versions ARRAY-OF-VERSION-STRINGS
)


Works for you?

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

@Josh: Currently it is possible to change a lot of fields on a release row. I suppose that will also be a DBA-only action as well? Also, the current "add" function expects start and end dates, a throttle value and whether it is featured or not. Are we basically changing the way we handle products/versions and thus should change the UI consequently? 

If your answers are "yes" and "yes", then that spec looks good to me.

Comment 3

[[:jberkus] Josh Berkus]

Yes and Yes.

While it was possible in the past to change dates and throttle values, it was never safe to do so.  And in the recent past we've had a number of temporary data-loss issues associated with users changing these values unwisely.

The idea is that Camino and open source users should be able to add releases to releases-raw via a simple admin interface.  Editing these would be complex as, depending on the amount of time which has passed, it might be necessary to modify multiple pieces of data in other tables.  Thus add, but not edit.

For the featured versions, it's not necessary for users to modify the other release information in order to feature specific versions, and it would in fact be easier if they didn't have to do so.

Comment 4

[[:jberkus] Josh Berkus]

Code written.  Pull request: https://github.com/mozilla/socorro/pull/564

Documentation of new functions is here (bottom of page): https://github.com/jberkus/socorro/blob/master/docs/databaseadminfunctions.rst

Anything else you need?

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

@Josh: can you please confirm the type of data you expect? 

  product_name > string e.g. 'Firefox'
  version > string e.g. '14.0a1'
  release_channel > string in ['Release', 'Beta', 'Aurora', 'Nightly']
  build_id > int
  platform > string e.g. 'Windows NT', 'Mac OS X'... 
  beta_number > int?? (is this for rapid-betas? )
  repository > string e.g. 'mozilla-central'

When adding a new release from the UI, do we expect the user to know and provide all information listed here?

Comment 6

[Laura Thomson :laura]

Should this be RESOLVED FIXED? or moved out?

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

Fixed, I was waiting to make sure we didn't miss anything but it seems to be good. I'll file other bugs if need be.