752234 - Guard nsOpusState::Time against inactive streams

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Today's nightly crashes with an arithmetic exception in nsOpusState::Time if the user loads an opus file with the media.opus.enable pref set to false. Oops.

Comment 1

[Ralph Giles (:rillian)]

Attachment: crash fix

This patch should have been included in bug 674225. :(

Comment 2

[Ralph Giles (:rillian)]

I can't reproduce with my own build, but hopefully this fixes it.

Comment 3

[Ralph Giles (:rillian)]

Ok, I've reproduced on MacOS X 10.7.3 (XCode 4.3.2) on top of hg revision 79f78105c451, and confirmed the patch resolves the crash.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d443c790721f

Should there be a test for this?

Comment 5

[Ralph Giles (:rillian)]

Hmm. Not for this specific issue, but maybe we should have a 'successfully does nothing' test with the pref off.

Chris, what do you think? The media test suite already takes a long time to run.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

It would be nice to have a test, and it shouldn't add much to the tests' runtime duration.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d443c790721f

Comment 8

[Ralph Giles (:rillian)]

Confirming 15.0a1 (2012-05-07) Nightly on MacOS doesn't crash when loading an opus file. It now shows "Video can't be played because the file is corrupt" as intended.

Comment 9

[Ralph Giles (:rillian)]

Didn't mean to reopen.

Comment 10

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 621316
	Branch: mozilla-central => try
An error occurred while cloning https://hg.mozilla.org/mozilla-central.

Comment 11

[Ralph Giles (:rillian)]

That was some queue!