Last Comment Bug 752234 - Guard nsOpusState::Time against inactive streams
: Guard nsOpusState::Time against inactive streams
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86 Mac OS X
: -- critical (vote)
: mozilla15
Assigned To: Ralph Giles (:rillian) needinfo me
: Maire Reavy [:mreavy]
Depends on:
  Show dependency treegraph
Reported: 2012-05-05 09:50 PDT by Ralph Giles (:rillian) needinfo me
Modified: 2012-05-10 16:58 PDT (History)
2 users (show)
ryanvm: in‑testsuite?
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

crash fix (1.20 KB, patch)
2012-05-05 09:57 PDT, Ralph Giles (:rillian) needinfo me
cpearce: review+
Details | Diff | Splinter Review

Description Ralph Giles (:rillian) needinfo me 2012-05-05 09:50:22 PDT
Today's nightly crashes with an arithmetic exception in nsOpusState::Time if the user loads an opus file with the media.opus.enable pref set to false. Oops.
Comment 1 Ralph Giles (:rillian) needinfo me 2012-05-05 09:57:15 PDT
Created attachment 621316 [details] [diff] [review]
crash fix

This patch should have been included in bug 674225. :(
Comment 2 Ralph Giles (:rillian) needinfo me 2012-05-05 11:01:28 PDT
I can't reproduce with my own build, but hopefully this fixes it.
Comment 3 Ralph Giles (:rillian) needinfo me 2012-05-05 11:46:20 PDT
Ok, I've reproduced on MacOS X 10.7.3 (XCode 4.3.2) on top of hg revision 79f78105c451, and confirmed the patch resolves the crash.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-05 20:48:16 PDT

Should there be a test for this?
Comment 5 Ralph Giles (:rillian) needinfo me 2012-05-05 21:24:39 PDT
Hmm. Not for this specific issue, but maybe we should have a 'successfully does nothing' test with the pref off.

Chris, what do you think? The media test suite already takes a long time to run.
Comment 6 Chris Pearce (:cpearce) 2012-05-06 13:54:37 PDT
It would be nice to have a test, and it shouldn't add much to the tests' runtime duration.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-05-06 17:35:38 PDT
Comment 8 Ralph Giles (:rillian) needinfo me 2012-05-07 08:09:28 PDT
Confirming 15.0a1 (2012-05-07) Nightly on MacOS doesn't crash when loading an opus file. It now shows "Video can't be played because the file is corrupt" as intended.
Comment 9 Ralph Giles (:rillian) needinfo me 2012-05-07 08:09:55 PDT
Didn't mean to reopen.
Comment 10 Mozilla RelEng Bot 2012-05-10 16:45:01 PDT
Autoland Patchset:
	Patches: 621316
	Branch: mozilla-central => try
An error occurred while cloning
Comment 11 Ralph Giles (:rillian) needinfo me 2012-05-10 16:58:54 PDT
That was some queue!

Note You need to log in before you can comment on or make changes to this bug.