Today's nightly crashes with an arithmetic exception in nsOpusState::Time if the user loads an opus file with the media.opus.enable pref set to false. Oops.
Created attachment 621316 [details] [diff] [review] crash fix This patch should have been included in bug 674225. :(
I can't reproduce with my own build, but hopefully this fixes it.
Ok, I've reproduced on MacOS X 10.7.3 (XCode 4.3.2) on top of hg revision 79f78105c451, and confirmed the patch resolves the crash.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d443c790721f Should there be a test for this?
Hmm. Not for this specific issue, but maybe we should have a 'successfully does nothing' test with the pref off. Chris, what do you think? The media test suite already takes a long time to run.
It would be nice to have a test, and it shouldn't add much to the tests' runtime duration.
Confirming 15.0a1 (2012-05-07) Nightly on MacOS doesn't crash when loading an opus file. It now shows "Video can't be played because the file is corrupt" as intended.
Didn't mean to reopen.
Autoland Patchset: Patches: 621316 Branch: mozilla-central => try An error occurred while cloning https://hg.mozilla.org/mozilla-central.
That was some queue!