The default bug view has changed. See this FAQ.

Guard nsOpusState::Time against inactive streams

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

Trunk
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Today's nightly crashes with an arithmetic exception in nsOpusState::Time if the user loads an opus file with the media.opus.enable pref set to false. Oops.
Created attachment 621316 [details] [diff] [review]
crash fix

This patch should have been included in bug 674225. :(
Severity: normal → critical
Whiteboard: [autoland-try:-b do -p all -u all]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u all] → [autoland-in-queue]
I can't reproduce with my own build, but hopefully this fixes it.
Attachment #621316 - Flags: review?(cpearce)
Ok, I've reproduced on MacOS X 10.7.3 (XCode 4.3.2) on top of hg revision 79f78105c451, and confirmed the patch resolves the crash.
Attachment #621316 - Flags: review?(cpearce) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/d443c790721f

Should there be a test for this?
Assignee: nobody → giles
Flags: in-testsuite?
Keywords: checkin-needed
Whiteboard: [autoland-in-queue]
Target Milestone: --- → mozilla15
Hmm. Not for this specific issue, but maybe we should have a 'successfully does nothing' test with the pref off.

Chris, what do you think? The media test suite already takes a long time to run.
It would be nice to have a test, and it shouldn't add much to the tests' runtime duration.
https://hg.mozilla.org/mozilla-central/rev/d443c790721f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Confirming 15.0a1 (2012-05-07) Nightly on MacOS doesn't crash when loading an opus file. It now shows "Video can't be played because the file is corrupt" as intended.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Didn't mean to reopen.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Comment 10

5 years ago
Autoland Patchset:
	Patches: 621316
	Branch: mozilla-central => try
An error occurred while cloning https://hg.mozilla.org/mozilla-central.
That was some queue!
You need to log in before you can comment on or make changes to this bug.