752308 - Using opacity:0 without restacking in add-on image light box causes context menu to apply to the last image in gallery

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[rctgamer3]

I uploaded new screenshots several months ago (because they were outdated).
The new screenshots appear on the carousel. Clicking on them (to enlarge the screenshot) (also) works just fine.
However, when i view the enlarged screenshot (directly), one of the old(er) screenshots appears.

Steps to reproduce:
1. Click the second image in the carousel (in the provided URL). The following image appears in the preview (and url hover):
https://static-ssl-cdn.addons.mozilla.net/img/uploads/previews/full/64/64667.png?modified=1320765472
(Do note the Unix timestamp, November 8, 2011, 3:17:52 pm UTC).

2. Directly view the image ("View Image"). The following image appears:
https://static-ssl-cdn.addons.mozilla.net/img/uploads/previews/full/22/22206.png?modified=1331247702
(Do note the (newer!) timestamp, March 8, 2012, 11:01:42 pm UTC)

Did something happen at this "March 8, 2012" date (AMO update?)

Could reproduce the bug (and timestamp) on ABP, MozMill and DOMi's details page.
https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/
https://addons.mozilla.org/en-US/firefox/addon/mozmill/
https://addons.mozilla.org/en-US/firefox/addon/dom-inspector-6622/

Comment 1

[rctgamer3]

Bump! The light box is still broken.

Comment 2

[Wil Clouser [:clouserw]]

Thanks Kris for figuring that out. :)

I'm not sure how hard this is to fix, but I assume someone who knows JS better could let me know.  I'll mark it [contribute] to see if there is some input.

Comment 3

[rctgamer3]

Attachment: Fix lightbox not restacking

Comment 4

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/2319e565bcc17c457db22983b0d9996587728e36

Thanks rctgamer3!