Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Alltabs graphic is displayed in the wrong vertical orientation

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 15.0
All
Mac OS X
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
With tabs on top the hanging tab of the alltabs graphic is wrong.
(Assignee)

Comment 1

5 years ago
Created attachment 621440 [details] [diff] [review]
new graphic

Simply a new graphic with a standing tab.

Andreas, maybe you have a better solution with more Lion style.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #621440 - Flags: review?(nisses.mail)
Comment on attachment 621440 [details] [diff] [review]
new graphic

We might as well make this icon similar in behaviour to the new toolbar icons in bug #709799. New graphics coming up!
Attachment #621440 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 621440 [details] [diff] [review]
new graphic

Oh, crap, I'm sorry, I put a + on the review instead of a - as I intended! (as I think we should fix the hover and active states)
Will remove checkin-needed flag as well.
Attachment #621440 - Flags: review+ → review-
Keywords: checkin-needed
Created attachment 621942 [details] [diff] [review]
new graphics and code

Asking Mike for review since he's been looking at similar code in bug #709799
Attachment #621440 - Attachment is obsolete: true
Attachment #621942 - Flags: review?(mconley)
(Assignee)

Comment 5

5 years ago
Created attachment 623175 [details] [diff] [review]
New patch

I removed a unneeded list-style-image definition and changed from :not([disabled="true"]):active to [open]. Now the icon is always dark when the popup is showing instead of a flashing.
Attachment #621942 - Attachment is obsolete: true
Attachment #621942 - Flags: review?(mconley)
Attachment #623175 - Flags: review?(mconley)
Comment on attachment 623175 [details] [diff] [review]
New patch

Review of attachment 623175 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good, but you might want to double-check with bwinton that the new appearance of the pressed button is what we want (ie, not dark).
Attachment #623175 - Flags: ui-review?(bwinton)
Attachment #623175 - Flags: review?(mconley)
Attachment #623175 - Flags: review+
Comment on attachment 623175 [details] [diff] [review]
New patch

Yeah, sure, I'll go for this.  ui-r=me!  :)
Attachment #623175 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/d898e6a9bf76
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.