Last Comment Bug 752347 - Alltabs graphic is displayed in the wrong vertical orientation
: Alltabs graphic is displayed in the wrong vertical orientation
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All Mac OS X
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Richard Marti (:Paenglab)
Depends on:
  Show dependency treegraph
Reported: 2012-05-06 11:21 PDT by Richard Marti (:Paenglab)
Modified: 2012-05-14 15:36 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

new graphic (782 bytes, patch)
2012-05-06 11:25 PDT, Richard Marti (:Paenglab)
bugs: review-
Details | Diff | Splinter Review
new graphics and code (2.12 KB, patch)
2012-05-08 05:51 PDT, Andreas Nilsson (:andreasn)
no flags Details | Diff | Splinter Review
New patch (1.94 KB, patch)
2012-05-11 09:00 PDT, Richard Marti (:Paenglab)
mconley: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Richard Marti (:Paenglab) 2012-05-06 11:21:00 PDT
With tabs on top the hanging tab of the alltabs graphic is wrong.
Comment 1 Richard Marti (:Paenglab) 2012-05-06 11:25:59 PDT
Created attachment 621440 [details] [diff] [review]
new graphic

Simply a new graphic with a standing tab.

Andreas, maybe you have a better solution with more Lion style.
Comment 2 Andreas Nilsson (:andreasn) 2012-05-07 08:50:16 PDT
Comment on attachment 621440 [details] [diff] [review]
new graphic

We might as well make this icon similar in behaviour to the new toolbar icons in bug #709799. New graphics coming up!
Comment 3 Andreas Nilsson (:andreasn) 2012-05-07 12:45:12 PDT
Comment on attachment 621440 [details] [diff] [review]
new graphic

Oh, crap, I'm sorry, I put a + on the review instead of a - as I intended! (as I think we should fix the hover and active states)
Will remove checkin-needed flag as well.
Comment 4 Andreas Nilsson (:andreasn) 2012-05-08 05:51:03 PDT
Created attachment 621942 [details] [diff] [review]
new graphics and code

Asking Mike for review since he's been looking at similar code in bug #709799
Comment 5 Richard Marti (:Paenglab) 2012-05-11 09:00:09 PDT
Created attachment 623175 [details] [diff] [review]
New patch

I removed a unneeded list-style-image definition and changed from :not([disabled="true"]):active to [open]. Now the icon is always dark when the popup is showing instead of a flashing.
Comment 6 Mike Conley (:mconley) 2012-05-11 09:07:26 PDT
Comment on attachment 623175 [details] [diff] [review]
New patch

Review of attachment 623175 [details] [diff] [review]:

The code looks good, but you might want to double-check with bwinton that the new appearance of the pressed button is what we want (ie, not dark).
Comment 7 Blake Winton (:bwinton) (:☕️) 2012-05-11 09:45:11 PDT
Comment on attachment 623175 [details] [diff] [review]
New patch

Yeah, sure, I'll go for this.  ui-r=me!  :)
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-05-14 15:36:51 PDT

Note You need to log in before you can comment on or make changes to this bug.