75236 - Dialog buttons initially disabled are blank (empty "label")

Status: VERIFIED WORKSFORME

(Core :: XUL, defect)

Description

[bobj]

If you popup the spellcheck dialog on an empty document, several of the dialog
buttons have no labels.  If the document has some text, the buttons labels
appear correctly.

This has been extracted from bug 70413 to create a new bug.

Comment 1

[Charles Manske]

This should be simple (will know after my build is finished) and should be
fixed asap.

Comment 2

[bobj]

Attachment: image showing blank dialog buttons

Comment 3

[Charles Manske]

I can't reproduce this with my 4/9/01 debug build.
Paul and editor QA guys: Can any of you?
Any problems in any other dialogs?

Comment 4

[sujay]

I'll check it out...

Comment 5

[shrirang khanzode]

not seen on my NT (today's build 0409)

Comment 6

[bobj]

I still see it with trunk build 2001040904 on US Win95.

Comment 7

[bobj]

BTW, today's (4/9) results look the same as the image already attached from
last week

Comment 8

[Charles Manske]

Sujay? What about platforms or Windows versions other than Win95?
Note the the buttons not showing up have the "disabled" attribute set "true"
during dialog startup. The text on these buttons is set in XUL, and we have
plenty of other dialogs that have disabled buttons, so this problem is quite
mysterious!

Comment 9

[sujay]

I see "Close" and "Recheck" buttons when doc is empty on Mac and Win.

Why should the rest of the buttons have labels if there is no text
in doc?

Comment 10

[Charles Manske]

Of course they should have labels! They are simply disabled (grayed text labels).

Comment 11

[sujay]

okay I see labels....then I guess its working...

Comment 12

[Charles Manske]

Which OS? Please test all.

Comment 13

[bobj]

With today's trunk build 2001040904 on US Win95, I found 2 additional
dialogs which seem to be having the same problem.

In mail, two dialogs from Edit|Mail/News Account Settings... panel have
blank buttons.  In the "Local Folders" and the "Outgoing Server (SMTP)"
dialogs, the 2 bottom buttons on the left side are blank.  I's assuming
they should be dimmed and disabled with labels: "Set As Default" and
"Remove Account".

I'll attach images.

Comment 14

[sujay]

Bob, can you retry with new profile ? thanks.

Comment 15

[bobj]

Attachment: other dialogs with blank buttons

Comment 16

[bobj]

Attachment: other dialogs with blank buttons (2nd try)

Comment 17

[bobj]

Ignore attachment from 04/09/01 16:24.  Something got corrupted.
It worked on the next try, so look at the attachment from 04/09/01 16:29.

Comment 18

[bobj]

Responding to sujay's 2001-04-09 16:14  comment:

Created new profile and reproduced blank buttons in the spellcheck,
the "Mail/News Account Settings...|Local Folders" and the "Mail/News Account 
Settings...|Outgoing Server (SMTP)" dialogs.

Still running trunk build 2001040904 on US Win95.

Comment 19

[Charles Manske]

Obviously it's not an editor or module-specific problem, but a XPFE or themes
problem.
Let's start with XPFE.
Joe Hewitt: See anything like this today?

Comment 20

[Charles Manske]

Changing summary

Comment 21

[Joe Hewitt (gone)]

I don't see this in my 4/9 build

Comment 22

[sujay]

qa_contact = jrgm...cc myself.

Comment 23

[John Morrison]

Actually, I could see this in an 04/05 build when using the modern skin, but
not when using classic. (By any chance, did anyone see this work in modern, or 
was it always working if checked in classic?)

From bobj's screenshots, he was using modern. Or, rather, "FrankenModern",
the transiently broken modern skin. 

When I tried to reproduce this in today's build on win2k (where modern appears 
to be fixed again), using either modern or classic, this problem is gone.

So, was this just fallout from the broken modern skin? Does this work for you 
in today's windows builds Bob?

Comment 24

[bobj]

No change.
Running trunk build 2001041004 on US Win95.
Classic Theme works fine.

Comment 25

[bobj]

Tried trunk build 2001041604 on US Win95.
Modern Theme works now...  Marking WORKSFORME.

Comment 26

[Chad Austin]

invalids, wontfixes, dups, worksformes