Closed
Bug 752609
Opened 13 years ago
Closed 12 years ago
[AccessFu] Shorten a11y event and role constant prefixes
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: eeejay, Assigned: yzen)
Details
Attachments
(1 file, 1 obsolete file)
|
25.45 KB,
patch
|
eeejay
:
review+
|
Details | Diff | Splinter Review |
We end up doing things like:
Ci.nsIAccessible.ROLE_DOCUMENT, or Ci.nsIAccessibleEvent.EVENT_DOCUMENT_LOAD_COMPLETE.
We should either add roles and events as global constants, or perhaps a global shortened name for the interface (e.g. gRole).
|
Assignee | |
Updated•12 years ago
|
QA Contact: yura.zenevich
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → yura.zenevich
QA Contact: yura.zenevich
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #769573 -
Flags: review?(eitan)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Reattaching with the 'patch' flag.
Attachment #769573 -
Attachment is obsolete: true
Attachment #769573 -
Flags: review?(eitan)
Attachment #769574 -
Flags: review?(eitan)
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 769574 [details] [diff] [review]
Patch for 752609.
Review of attachment 769574 [details] [diff] [review]:
-----------------------------------------------------------------
> +// Used for traversing in to child OOP frames.
> +const ROLE_INTERNAL_FRAME = Ci.nsIAccessibleRole.ROLE_INTERNAL_FRAME;
That comment appears down in the list. It shouldn't be here.
Besides that, this is great.
Attachment #769574 -
Flags: review?(eitan) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•