752690 - Various problems encountered with mozdevice when trying to get Google Chrome and Stock ICS working with Eideticker

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[William Lachance (:wlach)]

When trying to get google chrome and the ICS stock browser working with eideticker, I found a few problems with the way I had written the launchApplication method in droid.py:

* Google Chrome doesn't understand the way we quote the URL
* You can't set the right activity name for the stock browser: we want 'com.android.browser.BrowserActivity', but the way we expand things out you can only specify activity names like '.BrowserActivity' that are an expansion of the package name, which is 'com.google.android.browser' in ICS's case (so the only possibility is 'com.google.android.browser.<foo>' when what we need is 'com.android.browser.<foo>'). I didn't quite understand this before but now I do. :)
* There are various fennecisms in the method which do not correspond to the way android works. What we really need is to enable the user to provide an "extras" dictionary which the application can later access. For fennec, the types of extras we're interested in are "args" (simulated command line "arguments") and "env" (a list of environment variables which fennec should export). Other applications may want to do something different.

Fortunately droid.py is only used in Eideticker at the moment, so I have free rein to fix things. :)

Comment 1

[William Lachance (:wlach)]

Attachment: Improvements to devicemanager to make google chrome and stock ics launchable

I'm generally pretty happy with this patch. The one thing I'm a little uncertain about is my addition to a launchFennec method. As I say in the comments, I think it would go better in the mozrunner module (I think it's better to seperate mozdevice from actually managing firefox stuff as much as possible), but I'm not sure if *that* makes sense to do just yet as my "remote firefox runner" is still very much a work-in-progress. Maybe it's better just to leave it in eideticker-only for now? That's the only place it would be used.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 621736 [details] [diff] [review]
Improvements to devicemanager to make google chrome and stock ics launchable

Review of attachment 621736 [details] [diff] [review]:
-----------------------------------------------------------------

nice.  I suspect we will find yet another case in the future that will require some fiddling with this.  Overall I think it is a lot more generic now!

Comment 3

[William Lachance (:wlach)]

Inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/a9d94e8f4073

(removed some whitespace-only changes from the patch before applying)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9d94e8f4073