752729 - Cannot programmatically open a <select> element.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

Currently, browser.js intercepts a touch event from Android and uses SelectHelper to open a native dialog for the combo box elements, circumventing any DOM events. There is no way to programmatically open the combo box with a click() call, this is required for accessibility.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Open select dialog via DOM event instead of Android message.

I don't think there is reason to stop propogation since there seems to be no popup in android anyway. This has the added benefit of being simpler.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 621773 [details] [diff] [review]
Open select dialog via DOM event instead of Android message.

You'll need to update this line too, for XUL menulists:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/bindings.xml#97

I think you can just move the getListForElement call into SelectHelper.show, and then make the menulist binding call SelectHelper.show directly.

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> Comment on attachment 621773 [details] [diff] [review]
> Open select dialog via DOM event instead of Android message.
> 
> You'll need to update this line too, for XUL menulists:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> bindings.xml#97
> 
> I think you can just move the getListForElement call into SelectHelper.show,
> and then make the menulist binding call SelectHelper.show directly.

It won't do the uiBusy dance if we call show directly.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 752729 - Open select dialog via DOM event instead of Android message.

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 752729 - Open select dialog via DOM event instead of Android message. r=mbrubeck

Small refactor, removed disabled check since the binding checks this already and a clicked DOM event will not come up for a disabled control.

Comment 6

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e540d5d98b19

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e540d5d98b19