Closed Bug 752729 Opened 11 years ago Closed 11 years ago

Cannot programmatically open a <select> element.

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: eeejay, Assigned: eeejay)

Details

Attachments

(1 file, 2 obsolete files)

Currently, browser.js intercepts a touch event from Android and uses SelectHelper to open a native dialog for the combo box elements, circumventing any DOM events. There is no way to programmatically open the combo box with a click() call, this is required for accessibility.
I don't think there is reason to stop propogation since there seems to be no popup in android anyway. This has the added benefit of being simpler.
Attachment #621773 - Flags: review?(mbrubeck)
Comment on attachment 621773 [details] [diff] [review]
Open select dialog via DOM event instead of Android message.

You'll need to update this line too, for XUL menulists:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/bindings.xml#97

I think you can just move the getListForElement call into SelectHelper.show, and then make the menulist binding call SelectHelper.show directly.
Attachment #621773 - Flags: review?(mbrubeck) → review+
(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> Comment on attachment 621773 [details] [diff] [review]
> Open select dialog via DOM event instead of Android message.
> 
> You'll need to update this line too, for XUL menulists:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> bindings.xml#97
> 
> I think you can just move the getListForElement call into SelectHelper.show,
> and then make the menulist binding call SelectHelper.show directly.

It won't do the uiBusy dance if we call show directly.
Small refactor, removed disabled check since the binding checks this already and a clicked DOM event will not come up for a disabled control.
Attachment #621773 - Attachment is obsolete: true
Attachment #621786 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e540d5d98b19
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.