Delete the default/copy constructors and assignment operator from JSString, JSObject

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 621777 [details] [diff] [review]
Patch

Now that NewObjectCache doesn't embed a JSObject_Slots16 instance that needs a constructor on JSObject, this is easy for that case.  JSString is nearly as easy, just one test to fix up (in the manner that test's object-inspecting code already does).

Note that because these deletions inherit, we can get rid of deletions in all subclasses and still get errors on misuse.  Derived classes could implement these bits, to be sure, but that requires enough effort that I'm not too worried about it.  And any documentation value in having these redundantly in derived classes seems negligible -- best just to not have them.
Attachment #621777 - Flags: review?(luke)

Comment 1

5 years ago
Comment on attachment 621777 [details] [diff] [review]
Patch

Yes, please.
Attachment #621777 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f63aa66be6
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/e5f63aa66be6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.