Closed Bug 752742 Opened 13 years ago Closed 13 years ago

Show compatibility error if an add-on accesses _startMarker or _endMarker

Categories

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Product:
addons.mozilla.org Graveyard
Component:
Compatibility Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2012-05-24

People

(Reporter: jorgev, Assigned: basta)

Details

(Whiteboard: [fx13])

As explained in bug 731563, there were some changes in internal Places popup code that can affect add-ons. Particularly, the _startMarker and _endMarker variables have a different type, which is likely going to cause problems. We need to flag all instances of these variables being used and show an error. There's a possibility of false positives caused by variables with the same name, but it should be a small problem if any. This is a compatibility error, so the add-on should not be upgraded in this case. Message: The _startMarker and _endMarker variables have changed in a backward-incompatible way in Firefox 13. They are now element references instead of numeric indices. See <LINK> for more information. Link: https://bugzilla.mozilla.org/show_bug.cgi?id=731563 Affected add-on: https://addons.mozilla.org/en-US/firefox/addon/liveclick/
Merged into AMO: https://github.com/mozilla/amo-validator/commit/c1c574afae73f059bc76a1c915eeca2a3bc93e1d https://github.com/mozilla/zamboni/commit/22bf77e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: 2012-05-17 → 2012-05-24
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.