752752 - Reftest harness needs to set prefs to disable addon updates, to avoid leaking them

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11547389&tree=Firefox&full=1#error0
Rev4 MacOSX Snow Leopard 10.6 mozilla-central debug test crashtest on 2012-05-07 16:48:28 PDT for push 333626f688a4

Leaked URLs:
...
https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:reftest%40mozilla.org,uriloader%40pdf.js,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D?src=firefox&appOS=Darwin&appVersion=15.0a1&tMain=832&tFirstPaint=3851&tSessionRestored=179255

When http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#390 creates a profile it makes sure that safebrowsing and addon updates won't be hitting the network; reftests (and crashtests, and jsreftests) need to do the same.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11587879&tree=Mozilla-Inbound

Comment 2

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11687923&tree=Mozilla-Aurora

Comment 3

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11832108&tree=Mozilla-Inbound

Comment 4

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11899060&tree=Mozilla-Inbound

Comment 5

[Phil Ringnalda (:philor)]

Actually, comment 0 probably isn't addon updates - that's extensions.getAddons.getWithPerformance.url, unlike comment 4 which is extensions.update.background.url.

Comment 6

[Phil Ringnalda (:philor)]

Attachment: fix v.1

Is this enough to keep you from hitting AMO, or do I need to set all the URL prefs to something I don't know how to choose?

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 627440 [details] [diff] [review]
fix v.1

Review of attachment 627440 [details] [diff] [review]:
-----------------------------------------------------------------

If we assume they're not going to touch the Add-ons Manager (either via APIs or opening about:addons), then this will be enough.

Comment 8

[Phil Ringnalda (:philor)]

Attachment: With more verbose comments

My theory is that nothing run by the reftest harness can open about:addons or touch the addonmgr API, because it only runs content without any possibility of elevation. Might be wrong, but that's my theory.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 627861 [details] [diff] [review]
With more verbose comments

r=dbaron; sorry for the delay

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19f70f1fd34a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/19f70f1fd34a