Reftest harness needs to set prefs to disable addon updates, to avoid leaking them

RESOLVED FIXED in mozilla16

Status

Testing
Reftest
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

({intermittent-failure})

Trunk
mozilla16
intermittent-failure
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11547389&tree=Firefox&full=1#error0
Rev4 MacOSX Snow Leopard 10.6 mozilla-central debug test crashtest on 2012-05-07 16:48:28 PDT for push 333626f688a4

Leaked URLs:
...
https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:reftest%40mozilla.org,uriloader%40pdf.js,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D?src=firefox&appOS=Darwin&appVersion=15.0a1&tMain=832&tFirstPaint=3851&tSessionRestored=179255

When http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#390 creates a profile it makes sure that safebrowsing and addon updates won't be hitting the network; reftests (and crashtests, and jsreftests) need to do the same.
https://tbpl.mozilla.org/php/getParsedLog.php?id=11587879&tree=Mozilla-Inbound
Blocks: 753452
(Assignee)

Updated

6 years ago
No longer blocks: 753452
(Assignee)

Comment 2

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11687923&tree=Mozilla-Aurora
(Assignee)

Comment 3

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11832108&tree=Mozilla-Inbound
(Assignee)

Comment 4

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11899060&tree=Mozilla-Inbound
No longer blocks: 438871
(Assignee)

Updated

6 years ago
Blocks: 438871
(Assignee)

Comment 5

6 years ago
Actually, comment 0 probably isn't addon updates - that's extensions.getAddons.getWithPerformance.url, unlike comment 4 which is extensions.update.background.url.
(Assignee)

Comment 6

6 years ago
Created attachment 627440 [details] [diff] [review]
fix v.1

Is this enough to keep you from hitting AMO, or do I need to set all the URL prefs to something I don't know how to choose?
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #627440 - Flags: review?(bmcbride)
Comment on attachment 627440 [details] [diff] [review]
fix v.1

Review of attachment 627440 [details] [diff] [review]:
-----------------------------------------------------------------

If we assume they're not going to touch the Add-ons Manager (either via APIs or opening about:addons), then this will be enough.
Attachment #627440 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 8

6 years ago
Created attachment 627861 [details] [diff] [review]
With more verbose comments

My theory is that nothing run by the reftest harness can open about:addons or touch the addonmgr API, because it only runs content without any possibility of elevation. Might be wrong, but that's my theory.
Attachment #627440 - Attachment is obsolete: true
Attachment #627861 - Flags: review?(dbaron)
Comment on attachment 627861 [details] [diff] [review]
With more verbose comments

r=dbaron; sorry for the delay
Attachment #627861 - Flags: review?(dbaron) → review+
(Assignee)

Comment 10

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/19f70f1fd34a
https://hg.mozilla.org/mozilla-central/rev/19f70f1fd34a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.