752778 - Teach pywebsocket to send empty close frames

Status: RESOLVED DUPLICATE of bug 752776

(Core :: Networking: WebSockets, defect)

Description

[Jason Duell]

Attachment: Teach pywebsocket to send empty close frames

This is mainly for testing bug 748580.  It's also a minor spec issue--the spec suggests that endpoints ought to ack close messages with a close message with the same code as received, and this isn't possible in pywebsocket w/o this patch.

I've submitted the patch upstream:

   http://code.google.com/p/pywebsocket/issues/detail?id=123&thanks=123&ts=1336441544

Not sure I want to deal with maintaining a separate patch if they don't take it--thoughts?  I guess it wouldn't be that hard.

I guess we might as well hold off on reviewing this for now--if pywebsocket takes it, we can consider it reviewed...

Comment 1

[Jason Duell]

Attachment: v2: don't read 'reason' into string unless present in close msg

minor fix for case where code is present but reason isn't in network msg.

Comment 2

[Jason Duell]

Pywebsokcet v631 took my changes for handling empty close frames, so we'll fix this in bug 752776 by just upgrading pywebsocket.