Random orange: TEST-UNEXPECTED-FAIL | test-update-mailing-list.js::test_contact_in_mailing_list_updated (ml.addressLists is undefined)

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Address Book
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: mconley)

Tracking

({intermittent-failure})

Trunk
Thunderbird 15.0
All
Linux
intermittent-failure

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
TEST-START | /home/cltbld/talos-slave/test/build/mozmill/addrbook/test-update-mailing-list.js | test_contact_in_mailing_list_updated
Step Pass: {"function": "Controller.keypress()"}
Step Pass: {"function": "controller.click()"}
Test Failure: ml.addressLists is undefined
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/addrbook/test-update-mailing-list.js | test-update-mailing-list.js::test_contact_in_mailing_list_updated
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 108

5 years ago
Created attachment 626857 [details] [diff] [review]
Patch v1

So one feature of the tbpl bot is that it spams me until these oranges get fixed.

Welp, it worked I guess. Here's my first go at this. I've got a build baking on try.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Comment hidden (Treeherder Robot)
(Assignee)

Comment 110

5 years ago
Comment on attachment 626857 [details] [diff] [review]
Patch v1

So far, the build on try looks good:  https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=f6b279bd2735

I'm pumping the Mozmill tests a few times to see if I can get it to pop up again, but I'm reasonably certain it won't.

Mark - can you think of a more graceful way for me to get the mailing list from the address book, as opposed to iterating the childNodes? Or is that the way to go?
Attachment #626857 - Flags: review?(mbanner)
(Reporter)

Comment 111

5 years ago
Comment on attachment 626857 [details] [diff] [review]
Patch v1

iirc Mailing lists have URIs, so I think you may be able to use ml.URI and then re-use that later.

Also, I believe it is a general rule that you have to call hasMoreElements before getNext on enumerators, so that'd probably explain what's happening there.

Anyway this gets r=me as it fixes a highly frequent orange.
Attachment #626857 - Flags: review?(mbanner) → review+
(Assignee)

Comment 112

5 years ago
(In reply to Mark Banner (:standard8) from comment #111)
> Comment on attachment 626857 [details] [diff] [review]
> Patch v1
> 
> iirc Mailing lists have URIs, so I think you may be able to use ml.URI and
> then re-use that later.
> 

Thanks for the review. So it turns out that addMailList returns the added mailing list, so I'll use that.

> Anyway this gets r=me as it fixes a highly frequent orange.

Cheers!
(Assignee)

Comment 113

5 years ago
Created attachment 626937 [details] [diff] [review]
Patch v2 (carrying over r+ from Standard8)
Attachment #626857 - Attachment is obsolete: true
(Assignee)

Comment 114

5 years ago
comm-central: https://hg.mozilla.org/comm-central/rev/3b0f6d4281d9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Keywords: intermittent-failure
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.