752872 - (SQLite3.7.12.1) Upgrade to SQLite 3.7.12.1

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Mostly contains perf enhancements on windows FS, though the fix we really care about is better handling of antivirus software, due to bug 752732 (-wal and -shm files are converted into folders and antivirus protection waits more than 1 seconds on them).

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.12 - SQLite changes

This includes a fix to test_quota.c so that it'll compile on Windows. Otherwise, it fails because quota_FILE is using SQLITE_OS_WIN before it's defined. I've already sent a patch to drh for that issue.

For performance comparisons, it was built on top of the following revision:
https://hg.mozilla.org/mozilla-central/rev/95437bcc43dc

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.12 - Mozilla changes

Comment 3

[Ryan VanderMeulen [:RyanVM]]

"Green" on Try.
https://tbpl.mozilla.org/?tree=Try&rev=863a9ae0f9fb

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think they are about to release a 3.7.12.1 to address a crash

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Correct, though drh didn't think it would affect Mozilla. He also told me it would include the test_quota.c fix.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

so, maybe better to wait if it's matter of just some days, not sure what's the planned timetable.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

It was released today.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

New Try push:
https://tbpl.mozilla.org/?tree=Try&rev=87ecd64ddbd8

Based on parent changeset b038090f07c2:
https://hg.mozilla.org/mozilla-central/rev/b038090f07c2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.12.1 - SQLite changes

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.12.1 - Mozilla changes

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes

Review of attachment 626275 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +73,5 @@
>  GCONF_VERSION=1.2.1
>  GIO_VERSION=2.18
>  STARTUP_NOTIFICATION_VERSION=0.8
>  DBUS_VERSION=0.60
> +SQLITE_VERSION=3.7.12

specific reason this is not .1?

Comment 12

[Ryan VanderMeulen [:RyanVM]]

(In reply to Marco Bonardo [:mak] from comment #11)
> Comment on attachment 626275 [details] [diff] [review]
> Upgrade to SQLite 3.7.12.1 - Mozilla changes
> 
> Review of attachment 626275 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +73,5 @@
> >  GCONF_VERSION=1.2.1
> >  GIO_VERSION=2.18
> >  STARTUP_NOTIFICATION_VERSION=0.8
> >  DBUS_VERSION=0.60
> > +SQLITE_VERSION=3.7.12
> 
> specific reason this is not .1?

I didn't see a reason to force someone linking against a system library to use a release that fixes a Windows build issue and a crash that shouldn't affect Firefox. I don't feel that strongly about it, though. I can change it before landing if you prefer.

Comment 13

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes

as discussed on irc, let's add the .1 to the configure.
While doesn't matter much for Firefox, Storage may be used by xulrunner apps, and there's no reason to allow a version that potentially may segfault. Plus distro builders is unlikely will take .12 version that survived just a week, or less.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a44d302ac491
https://hg.mozilla.org/mozilla-central/rev/c3495842c662