Closed Bug 752872 (SQLite3.7.12.1) Opened 8 years ago Closed 8 years ago

Upgrade to SQLite 3.7.12.1

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: mak, Assigned: RyanVM)

References

Details

Attachments

(2 files, 2 obsolete files)

Mostly contains perf enhancements on windows FS, though the fix we really care about is better handling of antivirus software, due to bug 752732 (-wal and -shm files are converted into folders and antivirus protection waits more than 1 seconds on them).
Alias: SQLite3.7.12
Assignee: nobody → ryanvm
This includes a fix to test_quota.c so that it'll compile on Windows. Otherwise, it fails because quota_FILE is using SQLITE_OS_WIN before it's defined. I've already sent a patch to drh for that issue.

For performance comparisons, it was built on top of the following revision:
https://hg.mozilla.org/mozilla-central/rev/95437bcc43dc
Attachment #625207 - Flags: review?(mak77)
Attachment #625209 - Flags: review?(mak77)
I think they are about to release a 3.7.12.1 to address a crash
Correct, though drh didn't think it would affect Mozilla. He also told me it would include the test_quota.c fix.
so, maybe better to wait if it's matter of just some days, not sure what's the planned timetable.
New Try push:
https://tbpl.mozilla.org/?tree=Try&rev=87ecd64ddbd8

Based on parent changeset b038090f07c2:
https://hg.mozilla.org/mozilla-central/rev/b038090f07c2
Summary: Upgrade to SQLite 3.7.12 → Upgrade to SQLite 3.7.12.1
Attachment #625207 - Attachment is obsolete: true
Attachment #625207 - Flags: review?(mak77)
Attachment #626272 - Flags: review?(mak77)
Attachment #625209 - Attachment is obsolete: true
Attachment #625209 - Flags: review?(mak77)
Attachment #626275 - Flags: review?(mak77)
Alias: SQLite3.7.12 → SQLite3.7.12.1
Attachment #626272 - Flags: review?(mak77) → review+
Comment on attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes

Review of attachment 626275 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +73,5 @@
>  GCONF_VERSION=1.2.1
>  GIO_VERSION=2.18
>  STARTUP_NOTIFICATION_VERSION=0.8
>  DBUS_VERSION=0.60
> +SQLITE_VERSION=3.7.12

specific reason this is not .1?
(In reply to Marco Bonardo [:mak] from comment #11)
> Comment on attachment 626275 [details] [diff] [review]
> Upgrade to SQLite 3.7.12.1 - Mozilla changes
> 
> Review of attachment 626275 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +73,5 @@
> >  GCONF_VERSION=1.2.1
> >  GIO_VERSION=2.18
> >  STARTUP_NOTIFICATION_VERSION=0.8
> >  DBUS_VERSION=0.60
> > +SQLITE_VERSION=3.7.12
> 
> specific reason this is not .1?

I didn't see a reason to force someone linking against a system library to use a release that fixes a Windows build issue and a crash that shouldn't affect Firefox. I don't feel that strongly about it, though. I can change it before landing if you prefer.
Comment on attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes

as discussed on irc, let's add the .1 to the configure.
While doesn't matter much for Firefox, Storage may be used by xulrunner apps, and there's no reason to allow a version that potentially may segfault. Plus distro builders is unlikely will take .12 version that survived just a week, or less.
Attachment #626275 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/a44d302ac491
https://hg.mozilla.org/mozilla-central/rev/c3495842c662
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Blocks: SQLite3.7.13
You need to log in before you can comment on or make changes to this bug.