Bug 752872 (SQLite3.7.12.1)

Upgrade to SQLite 3.7.12.1

RESOLVED FIXED in mozilla15

Status

()

RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: mak, Assigned: RyanVM)

Tracking

Trunk
mozilla15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

7 years ago
Mostly contains perf enhancements on windows FS, though the fix we really care about is better handling of antivirus software, due to bug 752732 (-wal and -shm files are converted into folders and antivirus protection waits more than 1 seconds on them).
(Assignee)

Updated

7 years ago
Alias: SQLite3.7.12
Assignee: nobody → ryanvm
(Assignee)

Comment 1

7 years ago
Created attachment 625207 [details] [diff] [review]
Upgrade to SQLite 3.7.12 - SQLite changes

This includes a fix to test_quota.c so that it'll compile on Windows. Otherwise, it fails because quota_FILE is using SQLITE_OS_WIN before it's defined. I've already sent a patch to drh for that issue.

For performance comparisons, it was built on top of the following revision:
https://hg.mozilla.org/mozilla-central/rev/95437bcc43dc
Attachment #625207 - Flags: review?(mak77)
(Assignee)

Comment 2

7 years ago
Created attachment 625209 [details] [diff] [review]
Upgrade to SQLite 3.7.12 - Mozilla changes
Attachment #625209 - Flags: review?(mak77)
(Reporter)

Comment 4

7 years ago
I think they are about to release a 3.7.12.1 to address a crash
(Assignee)

Comment 5

7 years ago
Correct, though drh didn't think it would affect Mozilla. He also told me it would include the test_quota.c fix.
(Reporter)

Comment 6

7 years ago
so, maybe better to wait if it's matter of just some days, not sure what's the planned timetable.
It was released today.
(Assignee)

Comment 8

7 years ago
New Try push:
https://tbpl.mozilla.org/?tree=Try&rev=87ecd64ddbd8

Based on parent changeset b038090f07c2:
https://hg.mozilla.org/mozilla-central/rev/b038090f07c2
Summary: Upgrade to SQLite 3.7.12 → Upgrade to SQLite 3.7.12.1
(Assignee)

Comment 9

7 years ago
Created attachment 626272 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - SQLite changes
Attachment #625207 - Attachment is obsolete: true
Attachment #625207 - Flags: review?(mak77)
Attachment #626272 - Flags: review?(mak77)
(Assignee)

Comment 10

7 years ago
Created attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes
Attachment #625209 - Attachment is obsolete: true
Attachment #625209 - Flags: review?(mak77)
Attachment #626275 - Flags: review?(mak77)
(Reporter)

Updated

7 years ago
Alias: SQLite3.7.12 → SQLite3.7.12.1
(Reporter)

Updated

7 years ago
Attachment #626272 - Flags: review?(mak77) → review+
(Reporter)

Comment 11

7 years ago
Comment on attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes

Review of attachment 626275 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +73,5 @@
>  GCONF_VERSION=1.2.1
>  GIO_VERSION=2.18
>  STARTUP_NOTIFICATION_VERSION=0.8
>  DBUS_VERSION=0.60
> +SQLITE_VERSION=3.7.12

specific reason this is not .1?
(Assignee)

Comment 12

7 years ago
(In reply to Marco Bonardo [:mak] from comment #11)
> Comment on attachment 626275 [details] [diff] [review]
> Upgrade to SQLite 3.7.12.1 - Mozilla changes
> 
> Review of attachment 626275 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +73,5 @@
> >  GCONF_VERSION=1.2.1
> >  GIO_VERSION=2.18
> >  STARTUP_NOTIFICATION_VERSION=0.8
> >  DBUS_VERSION=0.60
> > +SQLITE_VERSION=3.7.12
> 
> specific reason this is not .1?

I didn't see a reason to force someone linking against a system library to use a release that fixes a Windows build issue and a crash that shouldn't affect Firefox. I don't feel that strongly about it, though. I can change it before landing if you prefer.
(Reporter)

Comment 13

7 years ago
Comment on attachment 626275 [details] [diff] [review]
Upgrade to SQLite 3.7.12.1 - Mozilla changes

as discussed on irc, let's add the .1 to the configure.
While doesn't matter much for Firefox, Storage may be used by xulrunner apps, and there's no reason to allow a version that potentially may segfault. Plus distro builders is unlikely will take .12 version that survived just a week, or less.
Attachment #626275 - Flags: review?(mak77) → review+
(Assignee)

Comment 14

7 years ago
https://hg.mozilla.org/mozilla-central/rev/a44d302ac491
https://hg.mozilla.org/mozilla-central/rev/c3495842c662
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Reporter)

Updated

6 years ago
Blocks: 764243
You need to log in before you can comment on or make changes to this bug.