752896 - Add 'DebuggerServer.addRequest'

Status: RESOLVED WONTFIX

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

Description from bug 751034 comment #10

(In reply to Jan Honza Odvarko from comment #10)
> What about having a 'DebuggerServer.addRequest' API that would allow to
> dynamically extend the 'BrowserRootActor.prototype.requestTypes' array (also
> from within an extension). This way we don't need to change
> dbg-browser-actors.js every time a new actor (a child of the root) appears.
> 
> DebuggerServer.addRequest = function DS_addRequest(aName, aFunction) {
>   DebuggerServer.BrowserRootActor.prototype.requestTypes[aName] =
> function(aRequest) {
>     return aFunction(this, aRequest);
>   }
> };
> 
> This would be similar to what is there for tab actors:
> 'DebuggerServer.addTabRequest'
> 
> The function could live in dbg-browser-actors.js 
> 
> Honza

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch (untested)

This patch compiles but is untested.

Comment 2

[Benoit Girard (:BenWa)]

Resolving as wont fix, I discussed this with :past and we decided we wouldn't do it this way. I though I had noted that here but apparently I wrote it in the wrong bug maybe :(?