Add 'DebuggerServer.addRequest'

RESOLVED WONTFIX

Status

()

Core
Gecko Profiler
RESOLVED WONTFIX
6 years ago
6 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Description from bug 751034 comment #10

(In reply to Jan Honza Odvarko from comment #10)
> What about having a 'DebuggerServer.addRequest' API that would allow to
> dynamically extend the 'BrowserRootActor.prototype.requestTypes' array (also
> from within an extension). This way we don't need to change
> dbg-browser-actors.js every time a new actor (a child of the root) appears.
> 
> DebuggerServer.addRequest = function DS_addRequest(aName, aFunction) {
>   DebuggerServer.BrowserRootActor.prototype.requestTypes[aName] =
> function(aRequest) {
>     return aFunction(this, aRequest);
>   }
> };
> 
> This would be similar to what is there for tab actors:
> 'DebuggerServer.addTabRequest'
> 
> The function could live in dbg-browser-actors.js 
> 
> Honza
(Assignee)

Comment 1

6 years ago
Created attachment 622044 [details] [diff] [review]
patch (untested)

This patch compiles but is untested.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Blocks: 751034
(Assignee)

Comment 2

6 years ago
Resolving as wont fix, I discussed this with :past and we decided we wouldn't do it this way. I though I had noted that here but apparently I wrote it in the wrong bug maybe :(?
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

6 years ago
No longer blocks: 751034
You need to log in before you can comment on or make changes to this bug.