752966 - Foopy kill_stalled.sh does not properly kill bcontroller.py

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Justin Wood (:Callek)]

Attachment: [tools] v1

We found out with our investigation into Bug 752222 that bcontroller.py hangs around far too long, and that kill_stalled.sh is not properly killing it off.

I decided to share code here, by using the stuff we already have in sut_tools for it.

Making this very simple since kill_stalled is called by humans.

Comment 1

[Mike Taylor [:bear]]

Comment on attachment 622026 [details] [diff] [review]
[tools] v1

can you make a small helper python script in sut_tools named tegra_checkstalled.py or something?

much easier to maintain going forward and easier to debug

Comment 2

[Justin Wood (:Callek)]

Attachment: [tools] v2

Comment 3

[Mike Taylor [:bear]]

Comment on attachment 622042 [details] [diff] [review]
[tools] v2

is this line supposed to be present?

+sys.exit(sut_lib.checkStalled('tegra-$tegra'))


if not, remove and r+

Comment 4

[Justin Wood (:Callek)]

Attachment: [tools] Part 2 -- minor fixup

Apparently I never tested this before checkin/review. This is not a critical fix, since I did not yet update kill_stalled.sh in /builds on the foopies.

This version is tested!

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 623217 [details] [diff] [review]
[tools] Part 2 -- minor fixup

http://hg.mozilla.org/build/tools/rev/35b1839b1ce1