Closed
Bug 753041
Opened 12 years ago
Closed 12 years ago
Fix 32-bit address sign extension
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: BenWa, Assigned: BenWa)
Details
Attachments
(1 file, 2 obsolete files)
|
4.78 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #622073 -
Flags: review?(jmuizelaar)
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → bgirard
Attachment #622073 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #622073 -
Flags: review?(jmuizelaar)
Attachment #622074 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #622074 -
Attachment is obsolete: true
Attachment #622074 -
Flags: review?(jmuizelaar)
Attachment #622075 -
Flags: review?(jmuizelaar)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 622075 [details] [diff] [review] patch Review of attachment 622075 [details] [diff] [review]: ----------------------------------------------------------------- ::: tools/profiler/TableTicker.cpp @@ +675,5 @@ > } else if (entry.mTagName == 'l') { > // Bug 739800 - Force l-tag addresses to have a "0x" prefix on all platforms > // Additionally, stringstream seemed to be ignoring formatter flags. > char tagBuff[1024]; > + unsigned long long pc = (unsigned long long)(uintptr_t)entry.mTagPtr; Please add a comment about why we're using a double cast.
Attachment #622075 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e5e371f13a
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c7e5e371f13a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•