Fix 32-bit address sign extension

RESOLVED FIXED in mozilla15

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 622073 [details] [diff] [review]
patch
Attachment #622073 - Flags: review?(jmuizelaar)
(Assignee)

Comment 1

5 years ago
Created attachment 622074 [details] [diff] [review]
right patch
Assignee: nobody → bgirard
Attachment #622073 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #622073 - Flags: review?(jmuizelaar)
Attachment #622074 - Flags: review?(jmuizelaar)
(Assignee)

Comment 2

5 years ago
Created attachment 622075 [details] [diff] [review]
patch
Attachment #622074 - Attachment is obsolete: true
Attachment #622074 - Flags: review?(jmuizelaar)
Attachment #622075 - Flags: review?(jmuizelaar)
Comment on attachment 622075 [details] [diff] [review]
patch

Review of attachment 622075 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ +675,5 @@
>    } else if (entry.mTagName == 'l') {
>      // Bug 739800 - Force l-tag addresses to have a "0x" prefix on all platforms
>      // Additionally, stringstream seemed to be ignoring formatter flags.
>      char tagBuff[1024];
> +    unsigned long long pc = (unsigned long long)(uintptr_t)entry.mTagPtr;

Please add a comment about why we're using a double cast.
Attachment #622075 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e5e371f13a
https://hg.mozilla.org/mozilla-central/rev/c7e5e371f13a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.