Last Comment Bug 753041 - Fix 32-bit address sign extension
: Fix 32-bit address sign extension
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Benoit Girard (:BenWa)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-08 12:07 PDT by Benoit Girard (:BenWa)
Modified: 2012-05-08 18:52 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.05 KB, patch)
2012-05-08 12:07 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Splinter Review
right patch (5.83 KB, patch)
2012-05-08 12:09 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Splinter Review
patch (4.78 KB, patch)
2012-05-08 12:10 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2012-05-08 12:07:28 PDT
Created attachment 622073 [details] [diff] [review]
patch
Comment 1 Benoit Girard (:BenWa) 2012-05-08 12:09:41 PDT
Created attachment 622074 [details] [diff] [review]
right patch
Comment 2 Benoit Girard (:BenWa) 2012-05-08 12:10:29 PDT
Created attachment 622075 [details] [diff] [review]
patch
Comment 3 Jeff Muizelaar [:jrmuizel] 2012-05-08 12:14:24 PDT
Comment on attachment 622075 [details] [diff] [review]
patch

Review of attachment 622075 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ +675,5 @@
>    } else if (entry.mTagName == 'l') {
>      // Bug 739800 - Force l-tag addresses to have a "0x" prefix on all platforms
>      // Additionally, stringstream seemed to be ignoring formatter flags.
>      char tagBuff[1024];
> +    unsigned long long pc = (unsigned long long)(uintptr_t)entry.mTagPtr;

Please add a comment about why we're using a double cast.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-05-08 18:52:34 PDT
https://hg.mozilla.org/mozilla-central/rev/c7e5e371f13a

Note You need to log in before you can comment on or make changes to this bug.