75307 - PathExpr::evaluate does the wrong thing for //

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The implementation of PathExpr::evaluate does some really strange things for // 
ops. Will attach a patch that should fix it. The patch also does some 
whitespace filtering. (this along with the patch in 75304 should be all 
whitespace filtering needed in the XPath engine)

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Comment 2

[Axel Hecht]

r=[e-mail]

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

-void PathExpr::fromDescendants
-    (PatternExpr* pExpr, Node* context, ContextState* cs, NodeSet* nodes)
+void PathExpr::evalDescendants
+    (PatternExpr* pExpr, Node* context, ContextState* cs, NodeSet* resNodes)
 {
-
-    if (( !context ) || (! pExpr )) return;
+    ExprResult *res = pExpr->evaluate(context, cs);
+    if (!res || res->getResultType() != ExprResult::NODESET) {
+        //XXX ErrorReport: report nonnodeset error


As you change the name of this, might it be worthwhile to change the signature
so that you can report failure to the caller?  (Perhaps in addition to making an
error report there.)  Seems like callers might really want to know if the
evaluation might fail.

Comment 4

[Axel Hecht]

ContextState inherits from ErrorObserver, so we had all we need.
(Though in this part of the code, there isn't really much to fail)

Axel

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'd rather that we waited with errorhandeling. The XPath engine needs to report 
errors on a ton of places and we havn't even decided exactly how all 
errorhandling should be done yet (ie what should be returned, what/when should 
be reported to the errorhandler)

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

OK, fair enough. sr=shaver.

Comment 7

[Axel Hecht]

Fix checked in, Axel

Comment 8

[Axel Hecht]

bitching buttons, verfication spam