753121 - failing test-content-worker.test:sample

Status: RESOLVED DUPLICATE of bug 751069

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Tinderbox is orange for Aurora because of:

error: TEST FAILED: test-content-worker.test:sample (timed out)

Also it looks like it because of thrown exception:

error: An exception occurred.
Traceback (most recent call last):
  File "}", line 1, in }:
  File "    self.on("message", function (data) {if (data == "hi!") {self.postMessage("bye!");}})", line NaN, in     self.on
  File "    var myLocation = window.location.toString()", line NaN, in     var myLocation = window.location.toString
  File "javascript", line NaN, in 
  File "}", line 2, in }:
  File "    self.on("message", function (data) {if (data == "hi!") {self.postMessage("bye!");}})", line NaN, in     self.on
  File "    var myLocation = window.location.toString()", line NaN, in     var myLocation = window.location.toString
  File "javascript", line NaN, in WorkerScope
TypeError: window.location is undefined

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The fix for this (bug 751077) landed in Nightly and has yet to be uplifted to Aurora.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

It looks like using document.location instead of window.location here:
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/tests/test-content-worker.js#L53

Solves the failure on Aurora, but I'm not sure what are the consequences of such change are. I find it little awkward that document.location is there while window.location is not and I think it maybe related to Bug 695480. Also this issue no longer appears on Nightly which suggests that maybe there was some regression that made it to Aurora but is already fixed in Nightly.

I'm CC-ing Alex to see if he has a better idea since he tracked down most of the issues "can't access dead object" exceptions which I suspect are related to this.