Create virtual env in objdir

RESOLVED FIXED in mozilla15

Status

Testing
Marionette
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Scribbling stuff into the src tree is just dirty.
Created attachment 622189 [details] [diff] [review]
v1

Use $GECKO_OBJDIR if set, otherwise $PWD. Also you now no longer need to cd into testing/marionette/client/marionette before running venv_test.sh. \o/
Assignee: nobody → philipp
Attachment #622189 - Flags: review?(jgriffin)
Comment on attachment 622189 [details] [diff] [review]
v1

Cool, thanks!

I'll update the testrunner so that it assumes relative test paths are relative to cwd instead of marionette.
Attachment #622189 - Flags: review?(jgriffin) → review+
Blocks: 753181
https://hg.mozilla.org/mozilla-central/rev/4d571c9e9ca6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Created attachment 622796 [details] [diff] [review]
if GECKO_OBJDIR is not set, create venv in pwd

we wouldn't actually set the VENV_DIR if GECKO_OBJDIR wasn't set, so VENV_DIR would just be set to 'marionette_venv'. Changed it to use $MARIONETTE_HOME
Attachment #622796 - Flags: review?(philipp)
(Assignee)

Updated

6 years ago
Attachment #622796 - Flags: review?(philipp) → review+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.