75318 - LDAP doesn't build on FreeBSD

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[Yancey Yeargan]

FreeBSD, like some other OS's, takes only one argument to the ctime function. 
The current code attempts to pass three arguments.

Comment 1

[Yancey Yeargan]

Attachment: Fixes LDAP on FreeBSD

Comment 2

[Yancey Yeargan]

The previously attached patch uses ctime( c ) and the following patch uses
ctime_r( c, b ).  Either will build on FreeBSD.  Choose the one most
appropriate.

Comment 3

[Yancey Yeargan]

Attachment: Fixes LDAP with ctime_r on FreeBSD

Comment 4

[Jim Dunn]

Why don't you just add "|| defined(FREEBSD)" to the end of the elif
on line 282 of mozilla/directory/c-sdk/ldap/include/portable.h

Comment 5

[Yancey Yeargan]

Gee, you're right!  That is a much more clean fix for this.  So why all the
#ifdef's in the directory/c-sdk/ldap/libraries/libldap/tmplout.c file?  It seems
like those should be handled in portable.h as well.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Yancey: so have you verified that jdunn's proposed fix works?  If so, shall I go
ahead and check it in?

Comment 7

[Yancey Yeargan]

Yes, jdunn's proposed fix does indeed work.  I fully believe that it is safe to 
check it in.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Whoops, I meant to take this bug before.  I will check in the proposed change on
the LDAPCSDK_40_BRANCH shortly.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Patch using jdunn's suggestion.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Fix checked in.

Comment 11

[scottputterman]

adding nsbeta1+ since needed for port to version 5 of the CSDK.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Reopening for landing on ldapcsdk_branch_50.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Trying to reopen again...

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

Checked in to ldapcsdk_branch_50.