753275 - [LSV] Fix path to all-locales for mobile in compare.py

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Milos Dinic [:Milos]]

Attachment: Fix for mobile all-locales path

Ever since all-locales file changed location in mobile, diff script is failing to do any diffs with error:

Traceback (most recent call last):
  File "compare.py", line 90, in <module>
    locales = map(lambda s:s.strip(),open(localesfile_path).readlines())
IOError: [Errno 2] No such file or directory: '../mozilla-central/mobile/locales/all-locales'
Traceback (most recent call last):
  File "compare.py", line 90, in <module>
    locales = map(lambda s:s.strip(),open(localesfile_path).readlines())
IOError: [Errno 2] No such file or directory: '../releases/mozilla-aurora/mobile/locales/all-locales'
Traceback (most recent call last):
  File "compare.py", line 90, in <module>
    locales = map(lambda s:s.strip(),open(localesfile_path).readlines())
IOError: [Errno 2] No such file or directory: '../releases/mozilla-beta/mobile/locales/all-locales'

Submitting a patch that fixes that.

Comment 1

[Staś Małolepszy :stas]

Comment on attachment 622340 [details] [diff] [review]
Fix for mobile all-locales path

Review of attachment 622340 [details] [diff] [review]:
-----------------------------------------------------------------

I'd probably go for something like the following, in case there are more apps in the future:

  all_locales = {
    'browser': 'locales',
    'mobile': 'android/locales',
  }
  localesfile_path = os.path.join(frm, app, all_locales[app], localesfile)

But your version is fine, r=me.

Comment 2

[Milos Dinic [:Milos]]

Thanks guys,

Landed in http://hg.mozilla.org/l10n/l10n-src-verification/rev/6916f4d8dc9a