753313 - Some divs and spans are created dynamically in debugger-view

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

That's bad.

Comment 2

[Victor Porof [:vporof][:vp]]

THIS IS HARD.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

I'm sorry.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v2

Rebased already.

Comment 5

[Rob Campbell [:rc] (:robcee)]

quit it!

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v3

Fixed invalid css we discussed about.
You knew this was going to happen.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 622797 [details] [diff] [review]
v2

in debugger-view.js

-    item.className = "empty list-item";
+    item.className = "list-item empty";

quibble: why the reordering?

looks good. See? That wasn't so hard!

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> Comment on attachment 622797 [details] [diff] [review]
> v2
> 
> in debugger-view.js
> 
> -    item.className = "empty list-item";
> +    item.className = "list-item empty";
> 
> quibble: why the reordering?
> 

Just consistency, we always use .major-selector .detail in debugger view. Doesn't affect UI.

> looks good. See? That wasn't so hard!

This should've been much easier.
Don't get me started on how .value is totally different for buttons, labels, and with virtually every XUL widget, plus how set/getAttribute("value") doesn't work as you would expect. I like XUL it's nice.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof from comment #8)
> This should've been much easier.
> Don't get me started on how .value is totally different for buttons, labels,
> and with virtually every XUL widget, plus how set/getAttribute("value")
> doesn't work as you would expect. I like XUL it's nice.

I so loooooove that part of XUL...

Comment 10

[Rob Campbell [:rc] (:robcee)]

it's like I've stumbled into a thread on mozillazine.

Comment 11

[Rob Campbell [:rc] (:robcee)]

sorry. spamming whiteboard comments now.

Comment 12

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #11)
> sorry. spamming whiteboard comments now.

This won't be ready to land for a while.

Comment 13

[Victor Porof [:vporof][:vp]]

Attachment: v3.1

Rebased.

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/c66729ab079f

Comment 15

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/c66729ab079f