Some divs and spans are created dynamically in debugger-view

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
That's bad.
(Assignee)

Updated

5 years ago
Blocks: 722317, 676586
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Updated

5 years ago
Duplicate of this bug: 722317
(Assignee)

Comment 2

5 years ago
THIS IS HARD.
(Assignee)

Comment 3

5 years ago
Created attachment 622784 [details] [diff] [review]
v1

I'm sorry.
Attachment #622784 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Depends on: 753651
(Assignee)

Updated

5 years ago
Blocks: 752834
(Assignee)

Comment 4

5 years ago
Created attachment 622797 [details] [diff] [review]
v2

Rebased already.
quit it!
(Assignee)

Comment 6

5 years ago
Created attachment 622822 [details] [diff] [review]
v3

Fixed invalid css we discussed about.
You knew this was going to happen.
Attachment #622784 - Attachment is obsolete: true
Attachment #622797 - Attachment is obsolete: true
Attachment #622784 - Flags: review?(rcampbell)
Attachment #622822 - Flags: review?(rcampbell)
Comment on attachment 622797 [details] [diff] [review]
v2

in debugger-view.js

-    item.className = "empty list-item";
+    item.className = "list-item empty";

quibble: why the reordering?

looks good. See? That wasn't so hard!
Attachment #622797 - Attachment is obsolete: false
Attachment #622797 - Flags: review+
Attachment #622797 - Attachment is obsolete: true
Attachment #622822 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 8

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> Comment on attachment 622797 [details] [diff] [review]
> v2
> 
> in debugger-view.js
> 
> -    item.className = "empty list-item";
> +    item.className = "list-item empty";
> 
> quibble: why the reordering?
> 

Just consistency, we always use .major-selector .detail in debugger view. Doesn't affect UI.

> looks good. See? That wasn't so hard!

This should've been much easier.
Don't get me started on how .value is totally different for buttons, labels, and with virtually every XUL widget, plus how set/getAttribute("value") doesn't work as you would expect. I like XUL it's nice.
(In reply to Victor Porof from comment #8)
> This should've been much easier.
> Don't get me started on how .value is totally different for buttons, labels,
> and with virtually every XUL widget, plus how set/getAttribute("value")
> doesn't work as you would expect. I like XUL it's nice.

I so loooooove that part of XUL...
it's like I've stumbled into a thread on mozillazine.
Whiteboard: [land-in-fx-team]
sorry. spamming whiteboard comments now.
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 12

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #11)
> sorry. spamming whiteboard comments now.

This won't be ready to land for a while.
(Assignee)

Comment 13

5 years ago
Created attachment 625516 [details] [diff] [review]
v3.1

Rebased.
(Assignee)

Updated

5 years ago
No longer blocks: 752834
(Assignee)

Updated

5 years ago
Blocks: 752834
https://hg.mozilla.org/integration/fx-team/rev/c66729ab079f
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c66729ab079f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.