Last Comment Bug 753478 - large icon versions in qute/mail/messageHeader.css not used and should be removed
: large icon versions in qute/mail/messageHeader.css not used and should be rem...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 15.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-09 12:26 PDT by Magnus Melin
Modified: 2012-05-14 15:37 PDT (History)
15 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.88 KB, patch)
2012-05-09 13:42 PDT, Richard Marti (:Paenglab)
bwinton: review+
Details | Diff | Review

Description Magnus Melin 2012-05-09 12:26:34 PDT
+++ This bug was initially created as a clone of Bug #456169 comment 15 +++

The rules for large versions of the icons in qute/mail/messageHeader.css is redundant, since we always use small icons. Someone should clean out those...

For instance

309 .hdrReplyAllButton {
310   list-style-image: url("chrome://messenger/skin/icons/mail-toolbar.png");
311   -moz-image-region: rect(0px 120px 24px 96px);
312 }
313 
314 toolbar[iconsize="small"] .hdrReplyAllButton {
315   list-style-image: url("chrome://messenger/skin/icons/mail-toolbar-small.png");
316   -moz-image-region: rect(0px 80px 16px 64px);
317 }

Here the first block is not used.
Comment 1 Richard Marti (:Paenglab) 2012-05-09 13:42:37 PDT
Created attachment 622496 [details] [diff] [review]
patch

Removed the "small" selectors and gave the small rules to the normal definitions. I've also removed the workaround for bug 562608 because this doesn't apply. The buttons have no .button-box to make the selectors working.
Comment 2 Blake Winton (:bwinton) (:☕️) 2012-05-14 11:44:00 PDT
Comment on attachment 622496 [details] [diff] [review]
patch

Looks good to me!

ui-r=me.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-05-14 15:37:13 PDT
https://hg.mozilla.org/comm-central/rev/bdfc9e0e2918

Note You need to log in before you can comment on or make changes to this bug.