The default bug view has changed. See this FAQ.

large icon versions in qute/mail/messageHeader.css not used and should be removed

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Theme
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Magnus Melin, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 15.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #456169 comment 15 +++

The rules for large versions of the icons in qute/mail/messageHeader.css is redundant, since we always use small icons. Someone should clean out those...

For instance

309 .hdrReplyAllButton {
310   list-style-image: url("chrome://messenger/skin/icons/mail-toolbar.png");
311   -moz-image-region: rect(0px 120px 24px 96px);
312 }
313 
314 toolbar[iconsize="small"] .hdrReplyAllButton {
315   list-style-image: url("chrome://messenger/skin/icons/mail-toolbar-small.png");
316   -moz-image-region: rect(0px 80px 16px 64px);
317 }

Here the first block is not used.
(Assignee)

Comment 1

5 years ago
Created attachment 622496 [details] [diff] [review]
patch

Removed the "small" selectors and gave the small rules to the normal definitions. I've also removed the workaround for bug 562608 because this doesn't apply. The buttons have no .button-box to make the selectors working.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #622496 - Flags: review?(bwinton)
Comment on attachment 622496 [details] [diff] [review]
patch

Looks good to me!

ui-r=me.
Attachment #622496 - Flags: review?(bwinton) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/bdfc9e0e2918
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.