Closed
Bug 753501
Opened 10 years ago
Closed 10 years ago
Add empty tooltool manifests to some platforms
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
Details
(Whiteboard: [tooltool])
Attachments
(5 files, 3 obsolete files)
1.50 KB,
patch
|
ted
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
6.06 KB,
patch
|
jhford
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
7.41 KB,
patch
|
jhford
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
23.81 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
1.76 KB,
patch
|
rail
:
review+
philor
:
checked-in+
|
Details | Diff | Splinter Review |
... so devs can easier test new toolkits. Platforms: linux{,64}{,-debug}, macosx64{,-debug}, android{,-xul}
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
I moved tooltool_url_list to localcofig's GLOBAL_VARS, so it's not platform specific anymore (no need to copy paste it around) and you can easily redefine it for staging/pp.
Attachment #622718 -
Flags: review?(jhford)
Assignee | ||
Comment 3•10 years ago
|
||
Inline comments incoming
Attachment #622719 -
Flags: review?(jhford)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 622719 [details] [diff] [review] buildbotcustom Review of attachment 622719 [details] [diff] [review]: ----------------------------------------------------------------- ::: process/factory.py @@ +768,5 @@ > mozharnessMultiOptions=None, > mock_packages=[], > tooltool_manifest_src=None, > tooltool_bootstrap="setup.sh", > + tooltool_url_list=None, Using None is safer @@ +1202,5 @@ > )) > if self.tooltool_manifest_src: > self.addStep(RetryingShellCommand( > name='fetch_tooltool_resources', > + command=[self.tooltool_script, '--url', self.tooltool_url_list[0], "python /tools/tooltool.py" ignores the shebang "/tools/tooltool.py" doesn't. @@ +1209,5 @@ > name='tooltool_bootstrap', > + command=['bash', '-c', > + 'if [ -e "%s" ]; then bash "%s"; fi' % \ > + (self.tooltool_bootstrap, self.tooltool_bootstrap)] > + )) I added this check to allow empty manifests. The patches can't be landed before we deploy tooltool.py to builders.
Updated•10 years ago
|
Attachment #622718 -
Flags: review?(jhford) → review+
Updated•10 years ago
|
Attachment #622719 -
Flags: review?(jhford) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Some enhancements and fixes. Still need to see how pretty is the output of Manifest.__eq__() and add download progress (optional) + some testing.
Attachment #622737 -
Flags: feedback?(jhford)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 622718 [details] [diff] [review] configs Probably I should define tooltool_manifest_src per branch and disable it by default in PLATFORM_VARS (except b2g).
Comment 7•10 years ago
|
||
Comment on attachment 622737 [details] [diff] [review] tooltool Please open a pull request on https://github.com/jhford/tooltool for this. The copy checked in here is a snapshot of that repository's tooltool. Also, there are tests that should be updated if behaviour is changed.
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to John Ford [:jhford] from comment #7) > Comment on attachment 622737 [details] [diff] [review] > tooltool > > Please open a pull request on https://github.com/jhford/tooltool for this. > The copy checked in here is a snapshot of that repository's tooltool. Also, > there are tests that should be updated if behaviour is changed. Woooo! Much better! Will do.
Assignee | ||
Updated•10 years ago
|
Attachment #622737 -
Attachment is obsolete: true
Attachment #622737 -
Flags: feedback?(jhford)
Assignee | ||
Comment 9•10 years ago
|
||
Sorry for rush with the first patch, this one is more conservative. Let's start using this on try only.
Attachment #622718 -
Attachment is obsolete: true
Attachment #622827 -
Flags: review?(jhford)
Assignee | ||
Comment 10•10 years ago
|
||
Almost copy/paste from /build/puppet
Attachment #623121 -
Flags: review?(jhford)
Updated•10 years ago
|
Attachment #622827 -
Flags: review?(jhford) → review+
Comment 11•10 years ago
|
||
Comment on attachment 623121 [details] [diff] [review] puppet-manifests my assumption is that this is using a tooltool.py that is mostly identical to the HEAD of github.com/jhford/tooltool. If that's correct, r+
Attachment #623121 -
Flags: review?(jhford) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 622717 [details] [diff] [review] empty manifests And the last piece! The hardest one. :)
Attachment #622717 -
Flags: review?(jhford)
Assignee | ||
Comment 13•10 years ago
|
||
One todo left: lion has python 2.7 installed, probably the patch for puppet-manifests will be resubmitted. :/
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 623121 [details] [diff] [review] puppet-manifests http://hg.mozilla.org/build/puppet-manifests/rev/073c226cc489
Attachment #623121 -
Flags: checked-in+
Assignee | ||
Comment 15•10 years ago
|
||
* Use "wheel" group, which is common for linux/mac
Attachment #623121 -
Attachment is obsolete: true
Attachment #624129 -
Flags: review?(bhearsum)
Updated•10 years ago
|
Attachment #624129 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 16•10 years ago
|
||
Comment on attachment 624129 [details] [diff] [review] puppet-manifests http://hg.mozilla.org/build/puppet-manifests/rev/bbea6dfcacfd
Attachment #624129 -
Flags: checked-in+
Assignee | ||
Comment 17•10 years ago
|
||
Comment on attachment 622717 [details] [diff] [review] empty manifests Need ted's rubber stamp here. Empty manifests passing staging tests.
Attachment #622717 -
Flags: review?(jhford) → review?(ted.mielczarek)
Comment 18•10 years ago
|
||
Comment on attachment 622717 [details] [diff] [review] empty manifests I have no idea what a tooltool manifest is, but if this makes your life easier then go ahead.
Attachment #622717 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [tooltool] → [Leave open after merge][tooltool]
Assignee | ||
Comment 19•10 years ago
|
||
Comment on attachment 622717 [details] [diff] [review] empty manifests https://hg.mozilla.org/integration/mozilla-inbound/rev/8ffae46336ed
Attachment #622717 -
Flags: checked-in+
Assignee | ||
Comment 20•10 years ago
|
||
Comment on attachment 622717 [details] [diff] [review] empty manifests It was backed out by khuey's "big hammer" (multiple backouts due to the tree's red status) https://hg.mozilla.org/integration/mozilla-inbound/rev/dad0e473e803
Attachment #622717 -
Flags: checked-in+ → checked-in-
Assignee | ||
Comment 21•10 years ago
|
||
Comment on attachment 622717 [details] [diff] [review] empty manifests http://hg.mozilla.org/integration/mozilla-inbound/rev/ff731bcba745
Attachment #622717 -
Flags: checked-in- → checked-in+
Assignee | ||
Comment 22•10 years ago
|
||
Comment on attachment 622719 [details] [diff] [review] buildbotcustom http://hg.mozilla.org/build/buildbotcustom/rev/dcc7c67d2612
Attachment #622719 -
Flags: checked-in+
Assignee | ||
Comment 23•10 years ago
|
||
Comment on attachment 622827 [details] [diff] [review] configs http://hg.mozilla.org/build/buildbot-configs/rev/9a3c8b17ea66
Attachment #622827 -
Flags: checked-in+
Comment 24•10 years ago
|
||
(In reply to Rail Aliiev [:rail] from comment #21) > Comment on attachment 622717 [details] [diff] [review] > empty manifests > > http://hg.mozilla.org/integration/mozilla-inbound/rev/ff731bcba745 https://hg.mozilla.org/mozilla-central/rev/ff731bcba745
Whiteboard: [Leave open after merge][tooltool] → [tooltool]
Comment 25•10 years ago
|
||
in production 2012-05-17 0750 PDT
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 26•10 years ago
|
||
Comment on attachment 622827 [details] [diff] [review] configs >+BRANCHES['try']['platforms']['android-xul']['tooltool_manifest_src'] = 'mobile/android-xul/config/tooltool-manifests/android It's a good thing that nobody cares about their Android results on try, much less their Android XUL results on try, because the manifest is in mobile/xul/ rather than mobile/android-xul/, so every single build since this landed has burned.
Comment 27•10 years ago
|
||
Attachment #625855 -
Flags: review?(rail)
Assignee | ||
Comment 28•10 years ago
|
||
Comment on attachment 625855 [details] [diff] [review] try xul config Bah! My bad...
Attachment #625855 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 29•10 years ago
|
||
Comment on attachment 625855 [details] [diff] [review] try xul config http://hg.mozilla.org/build/buildbot-configs/rev/d30c4e6286c2
Attachment #625855 -
Flags: checked-in+
Comment 30•10 years ago
|
||
Caught a reconfig yesterday, and I see green XUL builds.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: mozilla.org → Release Engineering
Updated•4 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•