Closed Bug 753565 Opened 9 years ago Closed 9 years ago

webapp.json incorrect on Mac

Categories

(Firefox Graveyard :: Web Apps, defect, P3)

All
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: marco, Assigned: marco)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
>    let json = {
>      "registryDir": this.profileFolder.path,
>      "app": {
>        "origin": this.launchURI.prePath,
>        "installOrigin": "apps.mozillalabs.com",
>        "manifest": this.manifest
>       }
>    };

This code shouldn't be correct.
Attachment #622537 - Flags: review?(felipc)
Priority: -- → P3
Target Milestone: --- → Firefox 15
No longer blocks: 731054
Comment on attachment 622537 [details] [diff] [review]
Patch

Marco, as the webapp.json file is needed on all platforms, and it is the same file on all of them, could you instead move the json object generation to a function outside of the platform-specific part, and use that in all platforms?

The writeToFile part can stay inside each part as the file path varies.
Attachment #622537 - Flags: review?(felipc)
Attached patch Patch v2Splinter Review
Assignee: nobody → mar.castelluccio
Attachment #622537 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #625488 - Flags: review?(felipc)
Comment on attachment 625488 [details] [diff] [review]
Patch v2

thank you!
Attachment #625488 - Flags: review?(felipc) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/81c7d89d9d06
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Internal code change - Does not look like anything needs verification.
Whiteboard: [qa-]
Flags: in-moztrap-
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.