Last Comment Bug 753565 - webapp.json incorrect on Mac
: webapp.json incorrect on Mac
Status: RESOLVED FIXED
[qa-]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Web Apps (show other bugs)
: Trunk
: All Mac OS X
: P3 normal
: Firefox 15
Assigned To: Marco Castelluccio [:marco]
: Jason Smith [:jsmith]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-09 15:22 PDT by Marco Castelluccio [:marco]
Modified: 2016-02-04 15:00 PST (History)
3 users (show)
jsmith: in‑moztrap-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.07 KB, patch)
2012-05-09 15:22 PDT, Marco Castelluccio [:marco]
no flags Details | Diff | Splinter Review
Patch v2 (2.79 KB, patch)
2012-05-20 06:59 PDT, Marco Castelluccio [:marco]
felipc: review+
Details | Diff | Splinter Review

Description Marco Castelluccio [:marco] 2012-05-09 15:22:29 PDT
Created attachment 622537 [details] [diff] [review]
Patch

>    let json = {
>      "registryDir": this.profileFolder.path,
>      "app": {
>        "origin": this.launchURI.prePath,
>        "installOrigin": "apps.mozillalabs.com",
>        "manifest": this.manifest
>       }
>    };

This code shouldn't be correct.
Comment 1 :Felipe Gomes (needinfo me!) 2012-05-20 03:17:34 PDT
Comment on attachment 622537 [details] [diff] [review]
Patch

Marco, as the webapp.json file is needed on all platforms, and it is the same file on all of them, could you instead move the json object generation to a function outside of the platform-specific part, and use that in all platforms?

The writeToFile part can stay inside each part as the file path varies.
Comment 2 Marco Castelluccio [:marco] 2012-05-20 06:59:11 PDT
Created attachment 625488 [details] [diff] [review]
Patch v2
Comment 3 :Felipe Gomes (needinfo me!) 2012-05-20 23:36:18 PDT
Comment on attachment 625488 [details] [diff] [review]
Patch v2

thank you!
Comment 4 Daniel Holbert [:dholbert] 2012-05-21 13:42:34 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/81c7d89d9d06
Comment 5 Ed Morley [:emorley] 2012-05-22 06:34:48 PDT
https://hg.mozilla.org/mozilla-central/rev/81c7d89d9d06
Comment 6 Jason Smith [:jsmith] 2012-05-22 08:03:17 PDT
Internal code change - Does not look like anything needs verification.

Note You need to log in before you can comment on or make changes to this bug.