webapp.json incorrect on Mac

RESOLVED FIXED in Firefox 15

Status

Firefox Graveyard
Web Apps
P3
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
Firefox 15
All
Mac OS X
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 622537 [details] [diff] [review]
Patch

>    let json = {
>      "registryDir": this.profileFolder.path,
>      "app": {
>        "origin": this.launchURI.prePath,
>        "installOrigin": "apps.mozillalabs.com",
>        "manifest": this.manifest
>       }
>    };

This code shouldn't be correct.
Attachment #622537 - Flags: review?(felipc)

Updated

5 years ago
Priority: -- → P3
Target Milestone: --- → Firefox 15

Updated

5 years ago
No longer blocks: 731054
Comment on attachment 622537 [details] [diff] [review]
Patch

Marco, as the webapp.json file is needed on all platforms, and it is the same file on all of them, could you instead move the json object generation to a function outside of the platform-specific part, and use that in all platforms?

The writeToFile part can stay inside each part as the file path varies.
Attachment #622537 - Flags: review?(felipc)
(Assignee)

Comment 2

5 years ago
Created attachment 625488 [details] [diff] [review]
Patch v2
Assignee: nobody → mar.castelluccio
Attachment #622537 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #625488 - Flags: review?(felipc)
Comment on attachment 625488 [details] [diff] [review]
Patch v2

thank you!
Attachment #625488 - Flags: review?(felipc) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/81c7d89d9d06
Keywords: checkin-needed
OS: Linux → Mac OS X
Hardware: x86_64 → All

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/81c7d89d9d06
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Internal code change - Does not look like anything needs verification.
Whiteboard: [qa-]

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.