[Page Thumbnails] Disabling thumbnails should not create empty folders

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jim Jeffery not reading bug-mail 1/2/11, Assigned: ttaubert)

Tracking

Trunk
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Turning off Thumbnails for the New Tab page should not create 'Empty Folders'

1. Add hidden pref: browser.pagethumbnails.capturing_disabled
2. Set value to 'True' 

With Firefox closed delete the thumbnails folder in your Profile.
Browse around and check back in your Profile - a New Thumbnail Folder was created on restart of the browser as one would expect. 

What one should not expect is to find numerous 'empty folders' being created as you continue to browse over time.  

Over just a few days after clearing the Thumbnails Folder there are now 271 Empty Folders.  I fear that something could creep into the folders and would remain buried and would be very hard to locate something hidden there by perhaps a malicious program.

Enabling the Hidden Pref should turn off creating of folders.
Component: General → Tabbed Browser
QA Contact: general → tabbed.browser
Summary: Disabling thumbnails should not create empty folders → [Page Thumbnails] Disabling thumbnails should not create empty folders
See Also: → bug 754671
(Assignee)

Updated

5 years ago
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
Created attachment 623677 [details] [diff] [review]
patch v1

This adds a {createPath: bool} flag to PageThumbsStorage.getFileForURL() so that we stop creating the file's path implicitly.
Attachment #623677 - Flags: review?(dietrich)
Comment on attachment 623677 [details] [diff] [review]
patch v1

Review of attachment 623677 [details] [diff] [review]:
-----------------------------------------------------------------

yay fileutils
Attachment #623677 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

5 years ago
Pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/92317d7fe1ee

and merged:

https://hg.mozilla.org/mozilla-central/rev/92317d7fe1ee
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.