753821 - changing status from Admin Disabled isn't restoring file

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Andrew Williamson [:eviljeff]]

Changing a version status from Disabled By Mozilla to 'pending preliminary review' or another non-Disabled state isn't making the xpi and contents available again like its supposed to.

The file contents view is empty and the xpi downloads a 0 bytes file.

(The old /admin/fix-disabled tool doesn't seem to fix the issue either).

e.g. https://addons.mozilla.org/en-US/firefox/files/browse/150505/
and 
https://addons.mozilla.org/firefox/downloads/file/150505/cycle_collector_analyzer_aboutccdump-0.4.3-fx+sm.xpi

Comment 1

[Kris Maglione [:kmag]]

If I had to guess, I'd say https://github.com/mozilla/zamboni/commit/ce741d7bfd11cbcc5a4a748c2beb82f9895bb4fb or the following commit is responsible.

Comment 2

[Kris Maglione [:kmag]]

To clarify, by 'the following commit', I meant the next commit that affected apps/files/models.py: https://github.com/mozilla/zamboni/commit/55b8a8880dc1a6fb81b6275a38ca48337c4cc8d1

Comment 3

[Gregory Koberger (:gkoberger)]

Cvan, how hard will this be to fix?

Comment 4

[Kris Maglione [:kmag]]

Everything seems to be working properly on my local install and on addons-dev.allizom.org. The files get copied to the mirror path and are accessible. On production, though, we get the right 302 when requesting the files, but they're not on the mirror.

As the code that restores disabled files is more or less the same as the code that does the initial copy to the mirrors, I can't guess what's wrong, but I really don't know enough (read anything) about the mirroring mechanics to look into it further.

Comment 5

[Wil Clouser [:clouserw]]

Mirrors will take a while (usually a couple minutes, but could be up to 30) before they will sync.  It should be on ftp.m.o within 5 minutes though.

Comment 6

[Kris Maglione [:kmag]]

This seems to have resolved itself.