Closed Bug 753845 Opened 7 years ago Closed 7 years ago
Race condition in select
Tab causes all manner of badness
If the runnable in selectTab() starts running before selectTab() finishes, isSelectedTab(tab) fails and a bunch of Important Things (TM) don't happen. Nom'ing for betaN+ blocker since this is probably the root cause for a bunch of bugs I've seen go by (things like titlebar not updating and such).
Attachment #622763 - Flags: review?(margaret.leibovic)
Comment on attachment 622763 [details] [diff] [review] Patch Good catch.
Attachment #622763 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 622763 [details] [diff] [review] Patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: randomly things won't update on switching tabs Testing completed (on m-c, etc.): locally Risk to taking this patch (and alternatives if risky): mobile-only String changes made by this patch: none
Attachment #622763 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #622763 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.