753845 - Race condition in selectTab causes all manner of badness

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

If the runnable in selectTab() starts running before selectTab() finishes, isSelectedTab(tab) fails and a bunch of Important Things (TM) don't happen.

Nom'ing for betaN+ blocker since this is probably the root cause for a bunch of bugs I've seen go by (things like titlebar not updating and such).

Comment 1

[:Margaret Leibovic]

Comment on attachment 622763 [details] [diff] [review]
Patch

Good catch.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33aee46739d7

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 622763 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: randomly things won't update on switching tabs
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): mobile-only
String changes made by this patch: none

Comment 4

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/33aee46739d7

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/039532eb1c0d