Race condition in selectTab causes all manner of badness

RESOLVED FIXED in Firefox 14

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 15
All
Android
Points:
---

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed, blocking-fennec1.0 +)

Details

Attachments

(1 attachment)

Created attachment 622763 [details] [diff] [review]
Patch

If the runnable in selectTab() starts running before selectTab() finishes, isSelectedTab(tab) fails and a bunch of Important Things (TM) don't happen.

Nom'ing for betaN+ blocker since this is probably the root cause for a bunch of bugs I've seen go by (things like titlebar not updating and such).
Attachment #622763 - Flags: review?(margaret.leibovic)

Comment 1

5 years ago
Comment on attachment 622763 [details] [diff] [review]
Patch

Good catch.
Attachment #622763 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/33aee46739d7
status-firefox14: --- → affected
status-firefox15: --- → fixed
Target Milestone: --- → Firefox 15
Comment on attachment 622763 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: randomly things won't update on switching tabs
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): mobile-only
String changes made by this patch: none
Attachment #622763 - Flags: approval-mozilla-aurora?
blocking-fennec1.0: ? → +
https://hg.mozilla.org/mozilla-central/rev/33aee46739d7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #622763 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/039532eb1c0d
status-firefox14: affected → fixed

Updated

5 years ago
No longer blocks: 745250

Updated

5 years ago
Blocks: 745250
You need to log in before you can comment on or make changes to this bug.