Closed Bug 753845 Opened 7 years ago Closed 7 years ago

Race condition in selectTab causes all manner of badness

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 15
Tracking Status
firefox14 --- fixed
firefox15 --- fixed
blocking-fennec1.0 --- +

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
If the runnable in selectTab() starts running before selectTab() finishes, isSelectedTab(tab) fails and a bunch of Important Things (TM) don't happen.

Nom'ing for betaN+ blocker since this is probably the root cause for a bunch of bugs I've seen go by (things like titlebar not updating and such).
Attachment #622763 - Flags: review?(margaret.leibovic)
Comment on attachment 622763 [details] [diff] [review]
Patch

Good catch.
Attachment #622763 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 622763 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: randomly things won't update on switching tabs
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): mobile-only
String changes made by this patch: none
Attachment #622763 - Flags: approval-mozilla-aurora?
blocking-fennec1.0: ? → +
https://hg.mozilla.org/mozilla-central/rev/33aee46739d7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #622763 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer blocks: 745250
Blocks: 745250
You need to log in before you can comment on or make changes to this bug.