753943 - Implement the Australis tabs on XP

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The same as bug 743629 but for XP

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch for XP

This patch is a adaption of the Aero implementation.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch for XP v2

I've added the hide separator of last tab in overflow mode for XP and also for the already landed Aero.

Comment 3

[Andreas Nilsson (:andreasn)]

This looks good in compability mode under Win7, but could you attach some sceenshots of Luna and Silver, just to be on the safe side?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Screenshot under Luna Silver

First tab is selected, second hovered.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Screenshot under Classic

Again first tab active, second hovered.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Screenshot with LW-theme

Comment 7

[Andreas Nilsson (:andreasn)]

I get the old fuzzyness-on-left-side with lots of tabs, but apart from that things looks good.

Comment 8

[Richard Marti (:Paenglab)]

Yeah, I have to change the width to 30px

+.tab-image-left,
+.tab-image-right {
+  width: 31px;

Should I ask for check-in or wait for the OSX patch?
Naturally with a patch with correct width.

Comment 9

[Andreas Nilsson (:andreasn)]

(In reply to Richard Marti [:paenglab] from comment #8)
> Yeah, I have to change the width to 30px
> 
> +.tab-image-left,
> +.tab-image-right {
> +  width: 31px;

This did not do any difference on my system. Something I observed is that is that the tabs change from fuzzy to sharp depending on the fact that the window size is a odd or even number.

Comment 10

[Andreas Nilsson (:andreasn)]

Comment on attachment 624380 [details] [diff] [review]
patch for XP v2

Cancelling review due to this being taken care of as well by #763308

Comment 11

[Richard Marti (:Paenglab)]

Fixed by Bug 763308