The default bug view has changed. See this FAQ.

Implement the Australis tabs on Linux

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 15.0
All
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
The same as bug 743629 but for Linux
(Assignee)

Comment 1

5 years ago
Created attachment 622836 [details] [diff] [review]
patch for Linux

This patch is a adaption of the Aero implementation.

I took the tab close graphics from the Australis for Linux Spec page <http://people.mozilla.com/~shorlander/files/australis-designSpecs/australis-designSpecs-linux-mainWindow.html>
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #622836 - Flags: ui-review?(nisses.mail)
Attachment #622836 - Flags: review?(nisses.mail)
(Assignee)

Comment 2

5 years ago
Do we have a Australis tracker bug for Linux?
(Assignee)

Comment 3

5 years ago
Created attachment 623455 [details] [diff] [review]
patch for Linux v2

Changed the margin and padding of the close button. With previous patch on hovering the close button the tab hover image changed easily to the next tab. This patch should solve this.
Attachment #622836 - Attachment is obsolete: true
Attachment #622836 - Flags: ui-review?(nisses.mail)
Attachment #622836 - Flags: review?(nisses.mail)
Attachment #623455 - Flags: ui-review?(nisses.mail)
Attachment #623455 - Flags: review?(nisses.mail)
Comment on attachment 623455 [details] [diff] [review]
patch for Linux v2

Looks good ui-wise when I tested on both light and dark themes. The close button needs down and right 1px. ui-r=me with that fixed.
Attachment #623455 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 623455 [details] [diff] [review]
patch for Linux v2

closeTab-active.svg have a lots of gaps in the xml (like on line 28), but apart from that all looks good. r=me with that fixed.
Attachment #623455 - Flags: review?(nisses.mail) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 624376 [details] [diff] [review]
Patch for check-in

Patch addressing the review comments.

Carrying over r+ and ui-r+
Attachment #623455 - Attachment is obsolete: true
Attachment #624376 - Flags: ui-review+
Attachment #624376 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
So, I think we need to talk a little about where we should be landing the australis stuff, since I don't really want us to ship a half-done version.  I'm hoping that we get a UX branch of Thunderbird sometime in the not-too-distant future, where we can land these things.  Until then, I think we should hold off on the checkin-needed, and perhaps even revert the previous checked-in patches, until we're all happy that the new theme is done.

Thanks,
Blake.
Keywords: checkin-needed
(Assignee)

Comment 8

5 years ago
Blake gave the ticket to land -> checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2b0f84659994
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
(Assignee)

Updated

5 years ago
Depends on: 763308
You need to log in before you can comment on or make changes to this bug.