Closed Bug 754087 Opened 12 years ago Closed 12 years ago

waitFor should share the script timeout

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: jgriffin, Assigned: jgriffin)

Details

Attachments

(1 file)

waitFor currently uses a hardcoded 10s timeout.  If waitFor times out inside of a script which also has a 10s script timeout, a race condition can occur between the two exceptions.
Attached patch patch v0.1Splinter Review
This lets us use the script timeout as the waitFor timeout, and removes the exception when waitFor fails, since the containing script will timeout.
Attachment #622947 - Flags: review?(mdas)
Attachment #622947 - Flags: review?(mdas) → review+
http://hg.mozilla.org/mozilla-central/rev/4c6d01c92dcc
Assignee: nobody → jgriffin
Target Milestone: --- → mozilla15
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: