Closed
Bug 754230
Opened 12 years ago
Closed 12 years ago
IA2::get_states should expose STATE_DEFUNCT if accessible is defunct
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: surkov, Assigned: oussamabadr)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])
Attachments
(1 file)
842 bytes,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
Reporter | ||
Comment 1•12 years ago
|
||
Oussama, you can take look at this one. It should be easy and nice.
Assignee | ||
Comment 2•12 years ago
|
||
OK, I will do ... :) you can assign me in, thks!!
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → oussamabadr
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to alexander :surkov from comment #0) > see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there. do you mean just to remove IsDefucnt() call within "if" statement ? or expose STATE_DEFUNCT if accessible isDefunct()? sorry, I mean expose IA2_STATE_DEFUNCT!!
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Oussama BADR from comment #3) > (In reply to alexander :surkov from comment #0) > > see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there. > > do you mean just to remove IsDefucnt() call within "if" statement ? > or expose STATE_DEFUNCT if accessible isDefunct()? the first means second
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #624036 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 6•12 years ago
|
||
Comment on attachment 624036 [details] [diff] [review] Patch to fix Bug 754230. Review of attachment 624036 [details] [diff] [review]: ----------------------------------------------------------------- r=me, thanks
Attachment #624036 -
Flags: review?(surkov.alexander) → review+
Reporter | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cde3ca0e2411
Target Milestone: --- → mozilla15
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cde3ca0e2411
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to alexander :surkov from comment #6) > Comment on attachment 624036 [details] [diff] [review] > Patch to fix Bug 754230. > > Review of attachment 624036 [details] [diff] [review]: > ----------------------------------------------------------------- > > r=me, thanks yw! thks to you, hungry for the next one ! (O_o)
Reporter | ||
Comment 10•12 years ago
|
||
take a look at bug 675879
You need to log in
before you can comment on or make changes to this bug.
Description
•