Closed Bug 754230 Opened 9 years ago Closed 9 years ago

IA2::get_states should expose STATE_DEFUNCT if accessible is defunct

Categories

(Core :: Disability Access APIs, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: surkov, Assigned: oussamabadr)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 file)

see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
Oussama, you can take look at this one. It should be easy and nice.
OK, I will do ... :)
you can assign me in, thks!!
Assignee: nobody → oussamabadr
(In reply to alexander :surkov from comment #0)
> see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.

do you mean just to remove IsDefucnt() call within "if" statement ?
or expose STATE_DEFUNCT if accessible isDefunct()?

sorry, I mean expose IA2_STATE_DEFUNCT!!
(In reply to Oussama BADR from comment #3)
> (In reply to alexander :surkov from comment #0)
> > see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
> 
> do you mean just to remove IsDefucnt() call within "if" statement ?
> or expose STATE_DEFUNCT if accessible isDefunct()?

the first means second
Attachment #624036 - Flags: review?(surkov.alexander)
Comment on attachment 624036 [details] [diff] [review]
Patch to fix Bug 754230.

Review of attachment 624036 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks
Attachment #624036 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/cde3ca0e2411
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(In reply to alexander :surkov from comment #6)
> Comment on attachment 624036 [details] [diff] [review]
> Patch to fix Bug 754230.
> 
> Review of attachment 624036 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, thanks

yw!
thks to you, hungry for the next one ! (O_o)
take a look at bug 675879
You need to log in before you can comment on or make changes to this bug.