Last Comment Bug 754230 - IA2::get_states should expose STATE_DEFUNCT if accessible is defunct
: IA2::get_states should expose STATE_DEFUNCT if accessible is defunct
Status: RESOLVED FIXED
[good first bug][mentor=hub@mozilla.c...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Oussama BADR
:
: alexander :surkov
Mentors:
Depends on:
Blocks: ia2
  Show dependency treegraph
 
Reported: 2012-05-11 04:00 PDT by alexander :surkov
Modified: 2012-05-17 02:32 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch to fix Bug 754230. (842 bytes, patch)
2012-05-15 07:48 PDT, Oussama BADR
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-05-11 04:00:09 PDT
see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
Comment 1 alexander :surkov 2012-05-13 06:51:20 PDT
Oussama, you can take look at this one. It should be easy and nice.
Comment 2 Oussama BADR 2012-05-14 00:06:10 PDT
OK, I will do ... :)
you can assign me in, thks!!
Comment 3 Oussama BADR 2012-05-14 03:39:01 PDT
(In reply to alexander :surkov from comment #0)
> see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.

do you mean just to remove IsDefucnt() call within "if" statement ?
or expose STATE_DEFUNCT if accessible isDefunct()?

sorry, I mean expose IA2_STATE_DEFUNCT!!
Comment 4 alexander :surkov 2012-05-14 05:52:30 PDT
(In reply to Oussama BADR from comment #3)
> (In reply to alexander :surkov from comment #0)
> > see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
> 
> do you mean just to remove IsDefucnt() call within "if" statement ?
> or expose STATE_DEFUNCT if accessible isDefunct()?

the first means second
Comment 5 Oussama BADR 2012-05-15 07:48:40 PDT
Created attachment 624036 [details] [diff] [review]
Patch to fix Bug 754230.
Comment 6 alexander :surkov 2012-05-15 21:56:02 PDT
Comment on attachment 624036 [details] [diff] [review]
Patch to fix Bug 754230.

Review of attachment 624036 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-05-16 19:47:15 PDT
https://hg.mozilla.org/mozilla-central/rev/cde3ca0e2411
Comment 9 Oussama BADR 2012-05-17 02:20:46 PDT
(In reply to alexander :surkov from comment #6)
> Comment on attachment 624036 [details] [diff] [review]
> Patch to fix Bug 754230.
> 
> Review of attachment 624036 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, thanks

yw!
thks to you, hungry for the next one ! (O_o)
Comment 10 alexander :surkov 2012-05-17 02:32:24 PDT
take a look at bug 675879

Note You need to log in before you can comment on or make changes to this bug.