IA2::get_states should expose STATE_DEFUNCT if accessible is defunct

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: Oussama BADR)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla15
All
Windows 7
access
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
(Reporter)

Comment 1

5 years ago
Oussama, you can take look at this one. It should be easy and nice.
(Assignee)

Comment 2

5 years ago
OK, I will do ... :)
you can assign me in, thks!!
(Reporter)

Updated

5 years ago
Assignee: nobody → oussamabadr
(Assignee)

Comment 3

5 years ago
(In reply to alexander :surkov from comment #0)
> see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.

do you mean just to remove IsDefucnt() call within "if" statement ?
or expose STATE_DEFUNCT if accessible isDefunct()?

sorry, I mean expose IA2_STATE_DEFUNCT!!
(Reporter)

Comment 4

5 years ago
(In reply to Oussama BADR from comment #3)
> (In reply to alexander :surkov from comment #0)
> > see msaa/nsAccessibleWrap::get_states. Just remove IsDefunct() call there.
> 
> do you mean just to remove IsDefucnt() call within "if" statement ?
> or expose STATE_DEFUNCT if accessible isDefunct()?

the first means second
(Assignee)

Comment 5

5 years ago
Created attachment 624036 [details] [diff] [review]
Patch to fix Bug 754230.
Attachment #624036 - Flags: review?(surkov.alexander)
(Reporter)

Comment 6

5 years ago
Comment on attachment 624036 [details] [diff] [review]
Patch to fix Bug 754230.

Review of attachment 624036 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks
Attachment #624036 - Flags: review?(surkov.alexander) → review+
(Reporter)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cde3ca0e2411
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/cde3ca0e2411
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(Assignee)

Comment 9

5 years ago
(In reply to alexander :surkov from comment #6)
> Comment on attachment 624036 [details] [diff] [review]
> Patch to fix Bug 754230.
> 
> Review of attachment 624036 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, thanks

yw!
thks to you, hungry for the next one ! (O_o)
(Reporter)

Comment 10

5 years ago
take a look at bug 675879
You need to log in before you can comment on or make changes to this bug.