754239 - Clear site preferences does not clear permanent security certificate exception for the website

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement)

Description

[Adrian Tamas (:AdrianT)]

Attachment: logs

Firefox Native 14.0b1 build 3
Device: HTC Desire (Android 2.2)

Steps to reproduce:
1. Go to https://fisheye.last.fm
2. Add a permanent SSL Certificate Error.
3. Try to clear the website preferences. 

Expected results:
Since there is no certificate manager clearing the site preferences should clear the certificate exception.

Actual results:
The security certificate exceptions are not clear. Without a certificate manager clearing user settings should also clear the certificate since an exception is a "Site preference".
Clearing private data also does not remove exceptions.

Comment 1

[Aaron Train [:aaronmt]]

This is basically a dupe of bug 436076.

Comment 2

[Gervase Markham [:gerv]]

aaronmt: I think you've misunderstood this bug. It is not a request for a certificate management UI. It is saying that if you add an SSL cert exception for a site, and then "clear site preferences" for that site, it should clear the exception. Which, given that we now have a per-site preferences system (don't we?), I believe it should.

Gerv

Comment 3

[Wesley Johnston (:wesj)]

We talked about adding this to the site settings dialog. I can mentor someone through that (or a different solution if we come up with one...)

Comment 4

[Manoj I]

Hi I am new to Mozilla. I would like to work on this.

manoji

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Wes is there additional info that would be helpful?

Comment 6

[Wesley Johnston (:wesj)]

Sorry for the delay. First step is to get a build done. If you're still interested, have you done that? The instructions at https://wiki.mozilla.org/Mobile/Fennec/Android are long, but thorough. The rest of this is just me digging around to see how you could fix this. I wouldn't bother reading it until you've got a build going :)

This clear site settings dialog is handled in the PermissionsHelper:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PermissionsHelper.js#45

You'll need to add an object for the cert override, and specify some strings for it in the properties file:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/chrome/browser.properties

The next step will be to implement something in getPermission to handle checking if there is a cert override for this host/port:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PermissionsHelper.js#122

I think we can use this getAllOverrideHostsWithPorts function from the certOverrideService. We'll have to loop over all the overrides and see if any matchthis page
http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/public/nsICertOverrideService.idl#117

You can see some other examples of us getting and using the service here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/exceptions.js#15

Finally, you'll need to actually clear the override when asked to. i.e. we'll have to special case this in here http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PermissionsHelper.js#152 and use the override service's clearValidityOverride method.

That's a bit vague of a braindump of what I think should work. Hollar if you need guidence on your way through it. And thanks!

Comment 7

[Manoj I]

Yes, very much interested . I built firefox thanks to some help form gcp . I will work on it this weekend , thanks for the info :).

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.