754268 - Send application version info from native to the front end

Status: RESOLVED FIXED

(Pancake Graveyard :: Native iOS Wrapper, defect)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed with https://bitbucket.org/mozillapancake/pancake-ios/changeset/820eff37ff87

The native app now responds to an "info" command that will return a dictionary with the following info:

{
    "applicationIdentifier": "com.mozilla.internal.PancakeDev",
    "applicationVersion": "1.0",
    "deviceJailbroken": false,
    "deviceModel": "iPad",
    "deviceSystemVersion": "5.1.1",
    "hardwareMachine": "iPad3,3",
    "hardwareModel": "J2aAP"
}

Let me know if we want to add anything else.

Comment 2

[Sam Foster [:sfoster] (he/him)]

I see that handleCallWithName handles the 'info' message, and returns the info I need, but where does it return it to? I can send an 'acknowlege' string in the request for this (and all messages) which will be a one-time message name to respond to this request in the origin window.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think the idea is that the FE grabs the version info from the native app and then submits to as part of lattice requests as described in https://bugzilla.mozilla.org/show_bug.cgi?id=754269

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Oops commented on the wrong bug

Comment 5

[Olivier Yiptong [:oyiptong]]

please also capture the network type. wireless or wifi

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed with https://bitbucket.org/mozillapancake/pancake-ios/changeset/a6d4dcb53cc3
{
    "applicationIdentifier": "com.mozilla.internal.PancakeDev",
    ...
    "networkConnectionType": "WWAN"
}

There are two options: WiFi and WWAN.

Comment 7

[Sam Foster [:sfoster] (he/him)]

I get the name/value pair reversed, so we get a X-Wifi header with value "networkConnectionType". Re-opening briefly while I fix this.

Comment 8

[Sam Foster [:sfoster] (he/him)]

We now get e.g.

GET /lattice/[e-mail]/stack/cf8ed349222b41028ef9b984d7627848/nodes HTTP/1.1
Host: colin.local:6543
User-Agent: Mozilla/5.0 (iPad; CPU OS 5_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Mobile/9B176
Accept: application/json
X-HardwareMachine: x86_64
X-DeviceSystemVersion: 5.1
X-HardwareModel: MacBookPro8,2
X-Requested-With: XMLHttpRequest
X-JsAppVersion: 1.0-localdev
X-NetworkConnectionType: WiFi
X-ApplicationIdentifier: com.mozilla.internal.PancakeDev
Referer: http://colin.local:6543/drawer?platform=ios
X-DeviceModel: iPad Simulator
X-ApplicationVersion: 1.0
X-DeviceJailbroken: false
Accept-Language: en-us
Accept-Encoding: gzip, deflate
Cookie: sessionid=b7687cbee787925b36945ed56555bf317e4b0890fd0f75d12dd747e29795e22b81437f13
Connection: keep-alive

..note: X-NetworkConnectionType: WiFi

But also note: 
GET /lattice/sfoster%40mozilla.com/stack/cf8ed349222b41028ef9b984d7627848/nodes HTTP/1.1
X-Applicationidentifier: com.mozilla.internal.PancakeDev
X-Hardwaremachine: x86_64
Accept-Encoding: gzip
X-Applicationversion: 1.0
Host: play.fxhome.mozillalabs.com:4322
X-Devicejailbroken: false
User-Agent: python-requests.org
Connection: close
X-Devicemodel: iPad Simulator
Cookie: sessionid=b7687cbee787925b36945ed56555bf317e4b0890fd0f75d12dd747e29795e22b81437f13
X-Networkconnectiontype: WiFi
X-Hardwaremodel: MacBookPro8,2
Content-Type: 
X-Jsappversion: 1.0-localdev
X-Devicesystemversion: 5.1

.. the case of the headers is different. Not sure if this is important? I'll assume not as it was this way before, and close.

Comment 9

[Sam Foster [:sfoster] (he/him)]

And added the X-NetworkConnectionTypes to the proxy's whitelist in: https://bitbucket.org/mozillapancake/pancake/changeset/911f8e0196e1

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uhhh are we sure we want to send and store all this info for every single request? Wouldn't it be better to do this once at the start of a session?

Comment 11

[Olivier Yiptong [:oyiptong]]

Actually, these could be sent on each stat or error log request.

And with less headers.

Comment 12

[Sam Foster [:sfoster] (he/him)]

Are we saying we should just add these headers in on requests to lattice/exceptions*and lattice/stat* ? Right now they are added to every lattice request.

Comment 13

[Olivier Yiptong [:oyiptong]]

Yep. It makes sense to only send them to those api endpoints

Comment 14

[Sam Foster [:sfoster] (he/him)]

Fixed in https://bitbucket.org/mozillapancake/pancake/changeset/8b634800e26c