754278 - Arguments passed in via executeScript or executeAsyncScript fail as they don't support floats

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

Selenuim Proxy was not able to execute this script, log below, because it passes in a float

2012-05-11 13:38:32,989 - Selenium-Proxy - INFO - Navigating to http://localhost:8019/javascriptPage.html - 13
2012-05-11 13:38:33,090 - Selenium-Proxy - DEBUG - /execute - {u'sessionId': u'13', u'args': [1.2], u'script': u'return arguments[0]'} - 13 - None
2012-05-11 13:38:33,090 - Selenium-Proxy - INFO - Executing Script - 13
2012-05-11 13:38:33,090 - Selenium-Proxy - CRITICAL - Server Exception: Traceback (most recent call last):
  File "selenium_proxy.py", line 221, in do_POST
    result = self.server.marionette.execute_script(body['script'], script_args=body['args'])
  File "/Users/davidburns/.virtualenvs/seleniumproxy/lib/python2.7/site-packages/marionette-0.2-py2.7.egg/marionette/marionette.py", line 327, in execute_script
    args = self.wrapArguments(script_args)
  File "/Users/davidburns/.virtualenvs/seleniumproxy/lib/python2.7/site-packages/marionette-0.2-py2.7.egg/marionette/marionette.py", line 283, in wrapArguments
    wrapped.append(self.wrapArguments(arg))
  File "/Users/davidburns/.virtualenvs/seleniumproxy/lib/python2.7/site-packages/marionette-0.2-py2.7.egg/marionette/marionette.py", line 294, in wrapArguments
    return wrapped
UnboundLocalError: local variable 'wrapped' referenced before assignment

Comment 1

[David Burns :automatedtester]

Attachment: add float check

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 623139 [details] [diff] [review]
add float check

Thanks!  Does this change allow the float test to pass?

Comment 3

[David Burns :automatedtester]

Attachment: Have added a test for new code

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 624140 [details] [diff] [review]
Have added a test for new code

Perfect, thanks.  Shall I land this in m-c and mirror to github?

Comment 5

[David Burns :automatedtester]

Committed to github 
https://github.com/mozilla/marionette_client/commit/1840721ba80dc3a5df8f5ff2bf5b379249ead2f3

Comment 6

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e9d5cc8e4559

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e9d5cc8e4559