Closed
Bug 754289
Opened 12 years ago
Closed 12 years ago
responsiveness should take a bool
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
Attachments
(1 file)
|
1.98 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
--responsiveness mistakenly did not note its type was bool. This causes it to eat the next flag on the command line and causes the PerfConfigurator (etc) to run badly. In addition we don't check for arguments to PerfConfigurator. It should take no args and we should check for this (as opposed to run_tests.py which does take arguments; different system :/)
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #623144 -
Flags: review?(jmaher)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 623144 [details] [diff] [review] fix Review of attachment 623144 [details] [diff] [review]: ----------------------------------------------------------------- thanks for the quick patch.
Attachment #623144 -
Flags: review?(jmaher) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
pushed: http://hg.mozilla.org/build/talos/rev/04b886eb1d4f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•