release_sanity.py does not recognize Thunderbird configs

RESOLVED FIXED

Status

Release Engineering
Release Automation
P2
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jhopkins, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
release_sanity.py does not recognize Thunderbird configs:

(build1)[cltbld@buildbot-master34 master]$ PYTHONPATH=. python ../tools/buildbot-helpers/release_sanity.py -u jhopkins -V 13.0b2 --branch comm-beta  --build-number 1 --release-config release-thunderbird-comm-beta.py --products thunderbird --dryrun localhost:9001
Traceback (most recent call last):
  File "../tools/buildbot-helpers/release_sanity.py", line 392, in <module>
    if not verify_branch(options.branch, releaseConfig['productName']):
  File "../tools/buildbot-helpers/release_sanity.py", line 88, in verify_branch
    if (productName != 'fennec' and branch not in masterConfig['release_branches']) or \
KeyError: 'release_branches'
Assignee: nobody → rail
Priority: -- → P2
Created attachment 628328 [details] [diff] [review]
updated release sanity and mozconfig whitelist

It worked fine for my staging comm-beta release. Haven't tested with other branches, but it shouldn't be a problem. It also removes 1.9.2 (yay!).

Throwing Nick's way since he's on the hook for Thunderbird 13.0 release.
Attachment #628328 - Flags: review?(nrthomas)
Comment on attachment 628328 [details] [diff] [review]
updated release sanity and mozconfig whitelist

>diff --git a/buildbot-helpers/mozconfig_whitelist b/buildbot-helpers/mozconfig_whitelist
>             # verify that mozconfigs for this release pass diff with nightly, compared to a whitelist
>             try:
>-                path = releaseConfig['sourceRepositories']['mozilla']['path']
>+                path = releaseConfig['sourceRepositories'][source_repo]['path']
>                 revision = releaseConfig['sourceRepositories']['mozilla']['revision']

Doesn't the revision need to be looked up in source_repo because the mozconfigs are in comm-<blah> ? Otherwise it looks like we'll fall back to mobile and fail that too. 

r+ with that fix and testing.
Attachment #628328 - Flags: review?(nrthomas) → review+
Comment on attachment 628328 [details] [diff] [review]
updated release sanity and mozconfig whitelist

Good catch!
http://hg.mozilla.org/build/tools/rev/0ce2440442da
Attachment #628328 - Flags: checked-in+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.