Call bad cert handler and SSL error listener asynchronously to avoid using SyncRunnableBase

RESOLVED WORKSFORME

Status

()

Core
Security: PSM
RESOLVED WORKSFORME
6 years ago
2 years ago

People

(Reporter: briansmith, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

AFAICT, we do not have to call the nsISSLErrorListener synchronously; it is OK to use normal event dispatching to the main thread. This will solve the second most common cause of deadlocks due to bug 729536.
This must be done for the bad cert handler too, at least in the synchronous cert verification case (i.e. for Thunderbird), to avoid bug 729536.
Summary: Call SSL error listener asynchronously to avoid using SyncRunnableBase → Call bad cert handler and SSL error listener asynchronously to avoid using SyncRunnableBase
Assignee: brian → nobody
nsISSLErrorListener was removed in bug 844351 and nsIBadCertListener2 dispatch only happens in CertErrorRunnable::CheckCertOverrides(), which only happens as part of running a CertErrorRunnable, which only happens on the main thread (as part of CertErrorRunnableRunnable running on the STS thread and dispatching the given CertErrorRunnable to the main thread and then waiting for it to finish). So, doesn't look like there's anything more to do here.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.