754427 - Social stacks do not show the user's profile page upon creation

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Olivier Yiptong [:oyiptong]]

Social stacks do not show the user's profile page upon creation. It does when the sidebar content is loaded from the server side.

Comment 1

[Gordon Brander :gordonb]

What do we get back from a POST to the social API?

    {
        "profile_place": {
            "id": "725d9504f1db4e3e904e874083c4a568",
            "thumbnail_key": "be2cc7b35be2814d5eb3414e74db0facdc46b6b91194c0eb4c633fbf"
        },
        "place": {
            "url": "http://www.buyolympia.com/q/Category=Triforce-Tribute",
            "title": "buyolympia.com/q/Category=Triforce-Tribute",
            "id": "46465fbd3dc84d93800fa1f964bf1a54",
            "thumbnail_key": "362a65e4601cfc9dea82fc8aeee47d0a535a6f31364a6566fbcf3ab3"
        },
        "stack": {
            "subtype": "social",
            "provider": "twitter.com",
            "id": "f1e341651d434793925f56bb140a669c",
            "title": "Always With Honor"
        },
        "session_id": "ed392b37dfb440d290caaec3501181a7",
        "thumbnails_job": null
    }

Need to make `social()` use:

* `process()`
* `onSuccess`

Comment 2

[Gordon Brander :gordonb]

`process()` already being used by `social`.

Comment 3

[Gordon Brander :gordonb]

Not sure where place_url field of Social landing pages should point... We eventually want to create a People page, but that does not currently exist.

Comment 5

[Gordon Brander :gordonb]

From DUPLICATE https://bugzilla.mozilla.org/show_bug.cgi?id=753894:

What happens:

* Click a social link for a person that does not yet have a stack
* Stack is created, drawer pans to places
* Place is shown. Person is NOT shown

What should happen:

* Click a social link for a person that does not yet have a stack
* Stack is created, drawer pans to places
* Place is shown. Person is shown beneath place

Now that we are no longer making a second round-trip to fetch drawer contents, we have to instantiate a SiteModel for the place and search place, appending to the PlacesCollection.

This is working for StackModel.search(), but is not yet hooked up for StackModel.social().

Comment 6

[Gordon Brander :gordonb]

Initial fix working. Need a person URL to point to. https://bitbucket.org/mozillapancake/pancake/changeset/20e8e049c167

Comment 7

[Gordon Brander :gordonb]

...and you can track progress in branch https://bitbucket.org/mozillapancake/pancake/changesets/tip/branch(%22social-stacks-creation%22)

Comment 8

[Gordon Brander :gordonb]

Fixed in https://bitbucket.org/mozillapancake/pancake/changeset/b4688e554202.

Using friend_url field from request to fill in for Person url.

NOTE: this will not work in the `views` iframe-based app, because of iframe access blocks on <http://twitter.com> and <http://facebook.com>.

Comment 9

[Gordon Brander :gordonb]

Added tests for processSearchPlace:

https://bitbucket.org/mozillapancake/pancake/changeset/aeae953d4a33
https://bitbucket.org/mozillapancake/pancake/changeset/328e51c448b4